Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd default date format to pagination #390
+7
−1
Conversation
ashawley
reviewed
Feb 12, 2019
{% else %} | ||
{{ post.date | date: "%b %-d, %Y" }} | ||
{% endif %} | ||
</p> |
This comment has been minimized.
This comment has been minimized.
ashawley
Feb 12, 2019
Author
Collaborator
Unlike #389, we have to use if-else. There's no way to use the default
feature of Liquid.
ashawley
force-pushed the
ashawley:default-date-format
branch
from
5a77565
to
f1a4c22
Feb 12, 2019
ashawley
merged commit 0f30943
into
johno:master
Feb 12, 2019
ashawley
deleted the
ashawley:default-date-format
branch
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ashawley commentedFeb 7, 2019
This is similar to #389. If people don't have this configured in their
_config.yml
, then things will break. This was also pulled from #334, since it shouldn't be a breaking change.