Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Peacock is creating new workspace settings when
With Peacock disabled:
I'm trying to understand what you are showing me above. I think you are showing first the user settings (if so, it is clearer to just type the setting value).
Then I think you are showing the values in the workspace settings. I assume those are the workspace settings after using peacock 3.1.1 --- but what was in that file before?
Also, can you check the output panel for what peacock logged, and post that here please?
This will help me better reproduce it. I just opened a new project with no workspace, using 3.1.1, and it did not create a settings.json for me. So I need some more details. Thanks in advance.
I have a theory .... try this:
If the settings.json file doesn't come back after doing this, then my theory is that the project where you saw this behavior may have been set to a color in a previous version of peacock. Peacock v2 used a memento (think of it as a hidden setting) to store the color. This was undesirable for many reasons (hard to see it, hard to track it, and users knew nothing about it). it also caused unpredictable behavior. Thus I removed this in v3. But, to help migrate people from v2 to v3, if I find the memento, I migrate it to the new
This is noted in the guide in the migration section. I would happily take suggestions or PRs for more docs, if it is not clear.
However, this may not be what you are experiencing. Another way to check this is if you can create a new folder (that has never had vs code open on it), then open vscode in it. Peacock does nothing in this case for me ... what does it do for you?
Correct. I gave the grep over my vscode config to prove that I have
It didn't exist. The above shell session shows:
I just ran this in a fresh directory on my home computer on Peacock 3.1.2 and it gave this output:
Just to show that it's in a fresh directory:
Again, here are my full vscode settings. At some point I created these workspace settings:
When I remove
It would be good if you could tell "is the current color different from the color set in the user's global config?" Is there any way in the vscode API to distinguish what's set globally vs what's set in the current workspace?
That was the key information I needed! Thanks! So you have a user settings.json color set. VS Code's API merges default settings and user settings and workspace settings together. So when peacock was checking if it should migrate, it saw you had a color set, and migrated for you.
What the code should be doing is checking if you have a color in the workspace only (as you point out here)
Yes, there is. It's not as easy as "give me the color" but I have the logic and I am currently testing it to make it sure it works and there are no regressions elsewhere.
Thank you for elaborating
Just to clarify, I mistyped "workspace" when I meant "workbench".
Just confirmed that on 3.1.4 no workspace