Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title and status bar borders #397

Closed
rudotriton opened this issue May 29, 2020 · 5 comments · Fixed by #408
Closed

Title and status bar borders #397

rudotriton opened this issue May 29, 2020 · 5 comments · Fixed by #408
Labels
bug Something isn't working

Comments

@rudotriton
Copy link

rudotriton commented May 29, 2020

On the status bar I have a button for "Remote Host" which I noticed isn't flush with the top edge of the bar anymore. I thought there is an issue with the button's alignment, I did some digging and played around with workbench customizations, eventually I found #377. As a result even if the theme doesn't have a status bar border, it is added:

Status bar border

This is what it looked like before and what it looks like when I remove the Peacock's border setting from the workspace settings:

Status bar border

For reference here is a theme that does have a border (Peacock's colored border is still turned off):

Status bar border

Above the theme's own border doesn't stand out as much, since the border color is effectively coordinated with the theme color.

I read through the aforementioned issue, however, I fail to understand why it was an issue in the first place, because the author had overwritten the border colors in the user settings. Anyway, they probably had a good reason for this.

Of course there are many ways to get around this cosmetic issue, ideally there would be an option to not paint the status bar border nor the title bar one, (someone may eventually notice that MacOS dims the title bar, but not the border and that becomes another annoyance), however, I'd like to have a discussion about what would be an appropriate solution here first. Thanks.

@johnpapa
Copy link
Owner

johnpapa commented May 29, 2020

Thank you @rudotriton for creating this issue!

@johnpapa
Copy link
Owner

johnpapa commented Jun 1, 2020

Thanks for raising this issue. I see your points and I agree that it looks like we may need to make a change.

I'd like to avoid introducing more settings and configuration, as it adds to the code complexity/maintenance and usability for some folks. But if that's where it leads, I'll take a look.

IIRC that issue was due to the specific theme the person was using which colored additional settings. Many themes likely did this, so I wanted to make sure Peacock accounted for it. I'll have to see how this can be fixed.

It would be awesome to have you and others be test cases for this, if you are willing?

@johnpapa johnpapa added the bug Something isn't working label Jun 1, 2020
@rudotriton
Copy link
Author

rudotriton commented Jun 2, 2020

Yes, I am definitely willing to be a test case.

I'm hoping there is a more convenient way of solving it, since this adds complexity, but maybe a possibility could be to extend the "Affect Accent Borders" setting to be more configurable and allow the user to specify which borders get affected.

@johnpapa
Copy link
Owner

johnpapa commented Aug 10, 2020

I added new property Affect Status and Title Borders, which defaults to false. When false, the borders will not be colored for title nor status. When true, the borders will be colored only if the title or status are also colored , respectively.

v3.8.0 will have this change.

@rudotriton
Copy link
Author

rudotriton commented Aug 11, 2020

thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants