From 7546d03d9514619894d23fe63bdf51129cda2141 Mon Sep 17 00:00:00 2001 From: Erich Gamma Date: Fri, 29 Nov 2019 15:38:23 +0100 Subject: [PATCH 1/2] Fix for #313 --- package.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 578c36d7..a5910c20 100644 --- a/package.json +++ b/package.json @@ -30,7 +30,10 @@ "activationEvents": [ "*" ], - "extensionKind": "ui", + "extensionKind": [ + "ui", + "workspace" + ], "main": "./dist/extension", "contributes": { "commands": [ From 6bad5621843580ecd31020be8e9ffeb4c004b0aa Mon Sep 17 00:00:00 2001 From: John Papa Date: Sun, 1 Dec 2019 22:33:44 -0500 Subject: [PATCH 2/2] changelog --- docs/changelog/README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/changelog/README.md b/docs/changelog/README.md index dd4b6edf..9f0b96f4 100644 --- a/docs/changelog/README.md +++ b/docs/changelog/README.md @@ -16,9 +16,13 @@ All notable changes to the code will be documented in this file. Fixes -- doc links to contriutions, code of conduct, and changelog from the guide are now fixed +- doc links to contributions, code of conduct, and changelog from the guide are now fixed - merged npm audit fixes for packages +- Adopt the new 'extensionKind' format. As per [Erich Gamma](https://github.com/egamma) from [PR #314 and Issue #313](https://github.com/johnpapa/vscode-peacock/pull/314) + +> As of VS Code 1.40 the `extensionKind` attribute in the `package.json` of the extension can be an array, pls see the documentation. We will be deprecating the string type for `extensionKind` property in favour of string array type. The `extensionKind` attribute should be set to `["ui", "workspace"]`. Indicating that the extension can run both as a UI extension and as a workspace extension (e.g. in the browser). + ## 3.2.0 Features