Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #313 #314

Merged
merged 3 commits into from Dec 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/changelog/README.md
Expand Up @@ -16,9 +16,13 @@ All notable changes to the code will be documented in this file.

Fixes

- doc links to contriutions, code of conduct, and changelog from the guide are now fixed
- doc links to contributions, code of conduct, and changelog from the guide are now fixed
- merged npm audit fixes for packages

- Adopt the new 'extensionKind' format. As per [Erich Gamma](https://github.com/egamma) from [PR #314 and Issue #313](https://github.com/johnpapa/vscode-peacock/pull/314)

> As of VS Code 1.40 the `extensionKind` attribute in the `package.json` of the extension can be an array, pls see the documentation. We will be deprecating the string type for `extensionKind` property in favour of string array type. The `extensionKind` attribute should be set to `["ui", "workspace"]`. Indicating that the extension can run both as a UI extension and as a workspace extension (e.g. in the browser).

## 3.2.0

Features
Expand Down
5 changes: 4 additions & 1 deletion package.json
Expand Up @@ -30,7 +30,10 @@
"activationEvents": [
"*"
],
"extensionKind": "ui",
"extensionKind": [
"ui",
"workspace"
],
"main": "./dist/extension",
"contributes": {
"commands": [
Expand Down