Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where workspace settings were written to implicitly. #361

Closed

Conversation

IEvangelist
Copy link

@IEvangelist IEvangelist commented Mar 4, 2020

Fixes: #360

  • Add a parameter to the applyColor function that allows the consumer to specify whether or not to update the workspace config
  • Fix typos in source comments
  • Fix typo in function name updateDarkenLightenPercentage
  • Update all references to applyColor accordingly

The issue was that on the activate function routine, the applyColor function was called during the addRemoteIntegration invocation. Workspace settings were updated regardless, of whether or not they needed to be. See #360 for more details.

@johnpapa
Copy link
Owner

@johnpapa johnpapa commented Mar 8, 2020

There are parts of this I really want to keep

  • misspellings
  • deeper look at your comments about remote integration and if that is causing wrong behavior

I’ll look into both and open issues for what I see. Thanks

@johnpapa johnpapa closed this Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants