Fixed a bug where workspace settings were written to implicitly.#361
Closed
IEvangelist wants to merge 1 commit into
Closed
Fixed a bug where workspace settings were written to implicitly.#361IEvangelist wants to merge 1 commit into
IEvangelist wants to merge 1 commit into
Conversation
Owner
|
There are parts of this I really want to keep
I’ll look into both and open issues for what I see. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #360
applyColorfunction that allows the consumer to specify whether or not to update the workspace configupdateDarkenLightenPercentageapplyColoraccordinglyThe issue was that on the
activatefunction routine, theapplyColorfunction was called during theaddRemoteIntegrationinvocation. Workspace settings were updated regardless, of whether or not they needed to be. See #360 for more details.