Skip to content

Fixed a bug where workspace settings were written to implicitly.#361

Closed
IEvangelist wants to merge 1 commit into
johnpapa:masterfrom
IEvangelist:explicitlyWriteSettings
Closed

Fixed a bug where workspace settings were written to implicitly.#361
IEvangelist wants to merge 1 commit into
johnpapa:masterfrom
IEvangelist:explicitlyWriteSettings

Conversation

@IEvangelist

Copy link
Copy Markdown

Fixes: #360

  • Add a parameter to the applyColor function that allows the consumer to specify whether or not to update the workspace config
  • Fix typos in source comments
  • Fix typo in function name updateDarkenLightenPercentage
  • Update all references to applyColor accordingly

The issue was that on the activate function routine, the applyColor function was called during the addRemoteIntegration invocation. Workspace settings were updated regardless, of whether or not they needed to be. See #360 for more details.

@johnpapa

johnpapa commented Mar 8, 2020

Copy link
Copy Markdown
Owner

There are parts of this I really want to keep

  • misspellings
  • deeper look at your comments about remote integration and if that is causing wrong behavior

I’ll look into both and open issues for what I see. Thanks

@johnpapa johnpapa closed this Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only update settings when the user explicitly selects a favorite color

2 participants