TBD: Return an existing Django type from get_internal_type #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this pull request for discussion only.
btw: the tests passed before and after, although they should have failed before (for Django 1.7). I've thought that just a call to
save()
should have triggered an error.Maybe it's related to sqlite being used, or because of TestModels being involved?!
(I could not get my hands on the durationfieldtest.db, even after commenting out "Destroying test database for alias ..." part from Django.
From the commit:
This is used in Django 1.7 migrations to derive the correct database
type from.
I cannot see, why "DurationField" should be returned here (added in
892b6e9).
This leaves
db_type
as-is, since it's used with older Django versionsand South probably.
Fixes #15.
Related Django ticket: https://code.djangoproject.com/ticket/22260