Resource files in dependencies are not relocated #114

Closed
johnrengelman opened this Issue Nov 24, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@johnrengelman
Owner

johnrengelman commented Nov 24, 2014

Same as #93 but for resource files in dependencies.

@johnrengelman johnrengelman added the bug label Nov 24, 2014

@johnrengelman johnrengelman added this to the 1.2.1 milestone Nov 24, 2014

@pron

This comment has been minimized.

Show comment
Hide comment
@pron

pron Nov 26, 2014

Hey. Do you have an estimated release date for 1.2.1?

pron commented Nov 26, 2014

Hey. Do you have an estimated release date for 1.2.1?

@sbuettner

This comment has been minimized.

Show comment
Hide comment
@sbuettner

sbuettner Jan 21, 2015

Would be really useful since relocating httpclient doesnt move all the property files it comes with.

shadowJar {
    exclude '**/version.properties'
    relocate 'org.apache', 'mypackage.org.apache'
}

Leaves the version.properties files inside the org.apache... packages.

Would be really useful since relocating httpclient doesnt move all the property files it comes with.

shadowJar {
    exclude '**/version.properties'
    relocate 'org.apache', 'mypackage.org.apache'
}

Leaves the version.properties files inside the org.apache... packages.

@johnrengelman

This comment has been minimized.

Show comment
Hide comment
@johnrengelman

johnrengelman Jan 23, 2015

Owner

Fixed and released. Sorry this took so long.

Owner

johnrengelman commented Jan 23, 2015

Fixed and released. Sorry this took so long.

@pron

This comment has been minimized.

Show comment
Hide comment
@pron

pron Jan 23, 2015

Yay! Thanks!

pron commented Jan 23, 2015

Yay! Thanks!

@pron

This comment has been minimized.

Show comment
Hide comment
@pron

pron Jan 25, 2015

Works great. Thanks again.

pron commented Jan 25, 2015

Works great. Thanks again.

@sbuettner

This comment has been minimized.

Show comment
Hide comment
@sbuettner

sbuettner Jan 26, 2015

Works great. Thank you. 🤘

Works great. Thank you. 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment