New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShadowCopyAction isn't closing input streams #364

Closed
dbrewster opened this Issue Mar 13, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@dbrewster

dbrewster commented Mar 13, 2018

Please check the User Guide before submitting "how do I do 'x'?" questions!

Shadow Version

2.0.2

Gradle Version

4.5

Expected Behavior

Everyplace the code is calling archive.getInputStream or otherwise opening a stream should be closed. For example, copyArchiveEntry should close the inputStream from archive.getInputStream as IOUtils.copyLarge does not.

Actual Behavior

Our build process runs out of file handles while building our shadow jars.

Gradle Build Script(s)

Content of Shadow JAR (jar tf <jar file> - post link to GIST if too long)

@johnrengelman

This comment has been minimized.

Owner

johnrengelman commented Apr 20, 2018

I've published 2.0.4-SNAPSHOT with this change, a release should be just a day away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment