Wildcard syntax for including\excluding doesn't work. #83

Closed
DmitriyMV opened this Issue Aug 14, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@DmitriyMV

include(dependency('asm:asm:3.*'))doesn't work. See also #64

@johnrengelman

This comment has been minimized.

Show comment
Hide comment
@johnrengelman

johnrengelman Aug 14, 2014

Owner

Try include(dependency('asm:asm'))

Owner

johnrengelman commented Aug 14, 2014

Try include(dependency('asm:asm'))

@DmitriyMV

This comment has been minimized.

Show comment
Hide comment
@DmitriyMV

DmitriyMV Aug 18, 2014

Try include(dependency('asm:asm'))

Works fine. Strange...

Try include(dependency('asm:asm'))

Works fine. Strange...

@johnrengelman

This comment has been minimized.

Show comment
Hide comment
@johnrengelman

johnrengelman Aug 18, 2014

Owner

Yeah, what's happening is the string is coerced into the Spec<ResolvedDependency> by splitting the string on :. So if there is not token in the field then it's not used in the spec. Just needs some love in that code to make it more robust and to allow pattern matching.

Owner

johnrengelman commented Aug 18, 2014

Yeah, what's happening is the string is coerced into the Spec<ResolvedDependency> by splitting the string on :. So if there is not token in the field then it's not used in the spec. Just needs some love in that code to make it more robust and to allow pattern matching.

@johnrengelman

This comment has been minimized.

Show comment
Hide comment
@johnrengelman

johnrengelman Nov 14, 2014

Owner

So, I'm going to fix this, but it's going to use regex pattern matching on the different pieces and not the maven style syntax. So it will be

include(dependency('asm:asm:.*'))
Owner

johnrengelman commented Nov 14, 2014

So, I'm going to fix this, but it's going to use regex pattern matching on the different pieces and not the maven style syntax. So it will be

include(dependency('asm:asm:.*'))

@johnrengelman johnrengelman modified the milestones: 1.2.0, 2.0.0 Nov 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment