Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add pull-to-refresh #11

Merged
merged 5 commits into from Mar 5, 2014

Conversation

Projects
None yet
2 participants
Member

richsage commented Feb 26, 2014

This adds pull-to-refresh functionality to listings:

  • Event listings (Hot/Upcoming/Past)
  • Talk listings for events
  • Event comments
  • Talk comments

This uses the functionality provided by the pull-to-refresh widget developed by @johannilsson

Member

Tocacar commented Mar 5, 2014

I have problems building this due to 2 errors:

  • in EventTalks.java, line 106, you're passing int, int, string to loadTalks() where it should be int, string, string
  • updateSubtitle() method in the same class is declared as void but returns 'talkCount'
Member

richsage commented Mar 5, 2014

OK, those errors should be fixed now.

Member

Tocacar commented Mar 5, 2014

All works fine on my mobile. An interesting observation is that, when a list is shorter than the page height, a 'Tap to Refresh' bar is displayed, however, when the list extends off the page, you are able to pull-to-refresh

http://imgur.com/4iGTdwz

Tocacar added a commit that referenced this pull request Mar 5, 2014

@Tocacar Tocacar merged commit a0b8e37 into joindin:master Mar 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment