Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ease unit testing #360

Merged
merged 3 commits into from Oct 10, 2016

Conversation

@heiglandreas
Copy link
Member

commented Oct 10, 2016

This change adds ways to omit the current calls to "header" and "exit" in the controllers to send certain headers or to circumvent the output of data to the client.

This change only renders output when content is provided, so when a controller-action returns "null" no output is rendered.

Additionally headers can now be set using a "setHeader"-method on the view, so direct calls to "header" aren't necessary any more

This addresses https://joindin.jira.com/browse/JOINDIN-700

This change adds ways to omit the current calls to "header" and "exit"
in the controllers to send certain headers or to circumvent the output
of data to the client.

This change only renders output when content is provided, so when a
controller-action returns "null" no output is rendered.

Additionally headers can now be set using a "setHeader"-method on the
view, so direct calls to "header" aren't necessary any more
Due to unit-tests instantiating the ApiView-Class directly those tests
now failed.
@railto railto merged commit 51aaae7 into joindin:master Oct 10, 2016
1 check passed
1 check passed
default Build finished.
Details
@heiglandreas heiglandreas deleted the heiglandreas:feature/easeUnitTesting branch Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.