[WIP] Consistency tidy up #97

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
3 participants
Owner

akrabat commented Mar 8, 2014

This PR just tidies up use statements.

Looks like a casing mistake in the alias - DbEVent. I presume the namespace alias is case insensitive because when we use this is doesn't cause any issues that I can see.

@lornajane lornajane commented on an outdated diff Mar 15, 2014

app/Joindin/Controller/Event.php
@@ -1,10 +1,10 @@
<?php
namespace Joindin\Controller;
-use Joindin\Model\Db\Talk;
-use \Joindin\Model\API\Event as EventApi;
-use \Joindin\Service\Cache as CacheService;
-
+use Joindin\Model\Db\Talk as DbTalk;
+use Joindin\Model\API\Event as EventApi;
+use Joindin\Service\Cache as Cache;
+use Joindin\Model\Db\Event as DbEVent;
@lornajane

lornajane Mar 15, 2014

Owner

Namespaces are case insensitive, but we could catch this s/DbEVent/DbEvent/ while we're here

@lornajane lornajane commented on an outdated diff Mar 15, 2014

app/Joindin/Controller/Event.php
@@ -1,10 +1,10 @@
<?php
namespace Joindin\Controller;
-use Joindin\Model\Db\Talk;
-use \Joindin\Model\API\Event as EventApi;
-use \Joindin\Service\Cache as CacheService;
-
+use Joindin\Model\Db\Talk as DbTalk;
+use Joindin\Model\API\Event as EventApi;
@lornajane

lornajane Mar 15, 2014

Owner

The other controllers have ApiEvent rather than EventApi, does it matter?

Owner

lornajane commented Mar 15, 2014

This patch is badly needed but I don't think we've quite nailed it. There are lots of places where the use statement changes but the code doesn't update - surely if we're not using that alias in the class anywhere it shouldn't be imported at the top? Or am I missing something else here?

akrabat changed the title from Consistency tidy up to [WIP] Consistency tidy up Mar 19, 2014

Owner

akrabat commented Mar 21, 2014

Closing. Better refactoring in #101

akrabat closed this Mar 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment