New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalize configuration properties #22

Closed
snicoll opened this Issue May 13, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@snicoll

snicoll commented May 13, 2016

I had a quick look at the code and I can see a lot of different prefixes for the configuration. A few thoughts:

  • Maybe it would be nicer if all options were gathered under a common prefix (something like jsf if that makes sense?)
  • If splitting the configuration by components is a good thing, maybe we should use the name of the component rather than a package name. This is a bit unusual compared to other libraries.

What do you think?

@persapiens

This comment has been minimized.

Show comment
Hide comment
@persapiens

persapiens May 13, 2016

Member

Current implementation uses the components (jsf api, mojarra, primefaces and omnifaces) context-param attributes, because it could help migration between traditional web.xml configuration to spring boot.

However, I agree that all of these properties should follow the same jsf namespace, creating subdomains for each component when necessary. The configuration of components should use the name of each component also.

So, jsf namespace should be:

  • jsf to standard jsf properties instead of javax.faces. For example javax.faces.PROJECT_STATE should be jsf.PROJECT_STATE
  • jsf.mojarra to mojarra properties instead of com.sun.faces.
  • jsf.omnifaces to omnifaces properties instead of omnifaces.
  • jsf.primefaces to primefaces properties instead of primefaces. For example, primefaces.THEME should be jsf.primefaces.THEME

More helpful suggestions @snicoll ?

Member

persapiens commented May 13, 2016

Current implementation uses the components (jsf api, mojarra, primefaces and omnifaces) context-param attributes, because it could help migration between traditional web.xml configuration to spring boot.

However, I agree that all of these properties should follow the same jsf namespace, creating subdomains for each component when necessary. The configuration of components should use the name of each component also.

So, jsf namespace should be:

  • jsf to standard jsf properties instead of javax.faces. For example javax.faces.PROJECT_STATE should be jsf.PROJECT_STATE
  • jsf.mojarra to mojarra properties instead of com.sun.faces.
  • jsf.omnifaces to omnifaces properties instead of omnifaces.
  • jsf.primefaces to primefaces properties instead of primefaces. For example, primefaces.THEME should be jsf.primefaces.THEME

More helpful suggestions @snicoll ?

@persapiens persapiens self-assigned this May 13, 2016

@persapiens persapiens added this to the 1.0.1 milestone May 13, 2016

persapiens added a commit that referenced this issue May 20, 2016

Update README.md
update documentation to reflect 1.1.0 release features.
Shows jsf namespace according to #22.
Include reference to myfaces library support.
@snicoll

This comment has been minimized.

Show comment
Hide comment
@snicoll

snicoll May 21, 2016

@persapiens apologies for the delay, I was quite busy this week. The change looks good to me, thanks!

snicoll commented May 21, 2016

@persapiens apologies for the delay, I was quite busy this week. The change looks good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment