Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Security support #29

Closed
cemo opened this issue May 23, 2016 · 10 comments
Closed

Spring Security support #29

cemo opened this issue May 23, 2016 · 10 comments
Assignees
Labels
Milestone

Comments

@cemo
Copy link

@cemo cemo commented May 23, 2016

Would you consider to add support Spring Security as well? What I have done before is stripping necessary components from spring-webflow and put inside our project. Using directly spring-webflow is bringing other dependencies that is why we are not using directly using them.

Here is the relevant part of it:

https://github.com/spring-projects/spring-webflow/tree/ae25f24443a1756b1149a95200bbe9f04a24f911/spring-faces/src/main/java/org/springframework/faces/security

@persapiens
Copy link
Member

@persapiens persapiens commented May 23, 2016

@cemo , I think jsf facelets spring security library is exactly what you're looking for. It does not uses spring-webflow.
However, it was deployed at google code and it is not able to download anymore :(
I will contact dominik (library author) to know if he could deploy to maven central.

@persapiens persapiens added the question label May 23, 2016
@persapiens
Copy link
Member

@persapiens persapiens commented May 23, 2016

@cemo what do you think about fork specific spring security facelets spring-webflow classes into these project? Create a separate project could be better approach?

@cemo
Copy link
Author

@cemo cemo commented May 23, 2016

Spring Team expects a contribution from community to support JSF. Almost all issues related to JSF has been marked as contributions welcome in JIRA.

I think that this project would be the correct place to gather community efforts.

So +1 to bring these classes into this project.

@persapiens
Copy link
Member

@persapiens persapiens commented May 23, 2016

Thank you for you comments @cemo. Let's do our best to improve JSF and Spring Boot ecosystem!

@domdorn answered me. His spring security facelets taglib is at github. He'll push maven central soon.

I'm a happy spring taglib-jsf20-spring-3 library user with jsf 2.2, spring 4.2 and springsecurity 4.2 versions.

The main advantage of spring security facelets taglib library over spring-webflow is that it is dedicated to solve jsf facelets and spring security integration. The facelets tags are equivalent. Maybe including all spring-webflow stuff is not a good solution at this moment.

@persapiens persapiens modified the milestone: 1.3.0 May 25, 2016
persapiens added a commit that referenced this issue May 29, 2016
… at jsf spring boot integration module.

mixed solution of from spring web flow at http://docs.spring.io/spring-webflow/docs/current/reference/html/spring-faces.html#spring-faces-security-taglib and from @domdorn at https://github.com/domdorn/spring-security-facelets-taglib 
Added springsecuritytaglib.xml including authorize, authenticated and anonymous tags and areAllGranted, areAnyGranted, areNotGranted, isAuthenticated and isAnonymous functions.
Include spring-security-taglibs dependency.
Client application has to include spring-boot-starter-security dependency.
@persapiens persapiens self-assigned this May 29, 2016
@persapiens
Copy link
Member

@persapiens persapiens commented May 29, 2016

@cemo , I've just pushed initial implementation of Spring Security Facelets Taglib support at JSF Spring Boot Starter integration submodule. (branch security)

It is a mixed solution from spring webflow and from @domdorn.

Added springsecuritytaglib.xml including authorize, authenticated and anonymous tags and areAllGranted, areAnyGranted, areNotGranted, isAllowed, isAuthenticated and isAnonymous functions.

JSF Spring Boot Starter included org.springframework.boot:spring-security-taglibs dependency. Client application has to include org.springframework.boot:spring-boot-starter-security dependency.

persapiens added a commit that referenced this issue May 30, 2016
@nyilmaz
Copy link
Contributor

@nyilmaz nyilmaz commented May 30, 2016

Great!! I'll give a try asap.

persapiens added a commit that referenced this issue May 30, 2016
Add FullyAuthorzize tag
@persapiens
Copy link
Member

@persapiens persapiens commented May 30, 2016

I've just pushed some changes related to reorganize classnames and introduced FullyAuthorized tag.

I look forward your accurate comments @nyilmaz

@nyilmaz
Copy link
Contributor

@nyilmaz nyilmaz commented May 31, 2016

I have successfully applied your snapshot version in which you did add taglibs. No problems so far. I also added a sample (in fact rearranged your example project). You can check it out @ nyilmaz/jsf-spring-boot-starter-example@6195ad2

@persapiens
Copy link
Member

@persapiens persapiens commented Jun 1, 2016

Thanks a lot. I'll release it today. I'll rearrange example project with your code too.

@persapiens
Copy link
Member

@persapiens persapiens commented Jun 1, 2016

Implemented in #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.