New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-think pom and project structure #455

Open
larsgrefer opened this Issue Apr 9, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@larsgrefer
Collaborator

larsgrefer commented Apr 9, 2018

According to https://github.com/spring-projects/spring-boot/wiki/Building-On-Spring-Boot#dependency-management third party projects (like Joinfaces in this case) should not require another parent-pom, but just provide a dependencies-pom to be imported via <dependencyManagement/>.

#384 was a first step in this direction, but Joinfaces still provides a parent pom and our maven example projects still use it.

Even if we wan't to keep the parent pom for external usage, we should clearly separate what we want to export to projects using Joinfaces and what is "Joinfaces-internal" and should not be exported.
While the dependencyManagement should be exported, other configuration like our checkstyle ruleset and coverage limits should stay internal.

@persapiens

This comment has been minimized.

Show comment
Hide comment
@persapiens

persapiens Apr 11, 2018

Member

I use joinfaces configuration from joinfaces-parent regularly on external projects, not only internal usage.

How could I reuse profiles (checkstyle, findbugs, cpd, pmd, duplicate) and properties (ex.: mojarra.version, primefaces.version) without using parent pom?

Member

persapiens commented Apr 11, 2018

I use joinfaces configuration from joinfaces-parent regularly on external projects, not only internal usage.

How could I reuse profiles (checkstyle, findbugs, cpd, pmd, duplicate) and properties (ex.: mojarra.version, primefaces.version) without using parent pom?

@larsgrefer larsgrefer referenced a pull request that will close this issue Oct 12, 2018

Open

[WIP] Try building Joinfaces with Gradle #539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment