New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SlapperTrait, cut down on duplicated code #144

Merged
merged 4 commits into from Jun 3, 2018

Conversation

Projects
None yet
2 participants
@dktapps
Collaborator

dktapps commented Apr 14, 2018

This hasn't been thoroughly tested. Utilize traits to reduce code duplication between different Slapper class extensions.

It may also be desirable to pair this with a Slapper interface.

@dktapps dktapps requested a review from jojoe77777 Apr 14, 2018

dktapps and others added some commits Apr 14, 2018

@jojoe77777 jojoe77777 merged commit bec37d2 into master Jun 3, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
poggit-ci/slapper Created PR build #16 (&42702): Lint passed
Details

@dktapps dktapps deleted the slapper-trait branch Jun 19, 2018

YTiStrafeNubzHD added a commit to YTiStrafeNubzHD/Slapper that referenced this pull request Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment