Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded SlapperTrait, cut down on duplicated code #144
Conversation
dktapps
requested a review
from
jojoe77777
Apr 14, 2018
dktapps
and others
added some commits
Apr 14, 2018
jojoe77777
merged commit bec37d2
into
master
Jun 3, 2018
dktapps
deleted the
slapper-trait
branch
Jun 19, 2018
added a commit
to YTiStrafeNubzHD/Slapper
that referenced
this pull request
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dktapps commentedApr 14, 2018
This hasn't been thoroughly tested. Utilize traits to reduce code duplication between different Slapper class extensions.
It may also be desirable to pair this with a
Slapperinterface.