Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syssetup #24

Merged
merged 45 commits into from Jul 25, 2019

Conversation

@azriel91
Copy link

commented Jul 24, 2019

  • Merged latest amethyst master (6a618bd).
  • Fixed all book snippets.
  • Examples compile, some fail due to resource insertion in Application::new
  • Examples work using the AmethystWorldExt trait to initialize the World.

Frizi and others added some commits Jul 19, 2019

Add clarification to Shape docs
It's not obvious that the size of the cube is 1 for newcomers like me, so it would be nice have this information in docs.
Also see gfx-rs/genmesh#38
Merge amethyst#1772
1772: More ergonomic RenderingBundle r=jaynus,happenslol,azriel91 a=Frizi

Fixes amethyst#1746

This adds a `RenderingBundle` with default `GraphCreator` which imlpements a plugin system for render graph creation. ~This is not yet fully complete, as it completely misses the buffers and compute nodes for now. It also needs tests. Still, early feedback very appreciated.~

Should be now complete enough to use :)

Co-authored-by: Frizi <frizi09@gmail.com>
Merge amethyst#1815
1815: Add clarification to Shape docs r=jojolepro a=TatriX


## Description

It's not obvious that the size of the cube is 1 for newcomers like me, so it would be nice have this information in docs.
Also see gfx-rs/genmesh#38

## PR Checklist

By placing an x in the boxes I certify that I have:

- [x] Updated the content of the book if this PR would make the book outdated.
- [x] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment.
- [x] Added unit tests for new code added in this PR.
- [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme.

If this modified or created any rs files:

- [ ] Ran `cargo +stable fmt --all`
- [ ] Ran `cargo clippy --all`
- [ ] Ran `cargo test --all --features "empty"`

Co-authored-by: TatriX <tatrics@gmail.com>
Merge amethyst#1817
1817: Corrected typos in prefabs aggregate chapter. r=jojolepro a=azriel91

Closes amethyst#1787.

- [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme.


Co-authored-by: Azriel Hoh <azriel91@gmail.com>

@jojolepro jojolepro merged commit 460962d into jojolepro:syssetup Jul 25, 2019

@jojolepro

This comment has been minimized.

Copy link
Owner

commented Jul 25, 2019

Feel free to push directly too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.