Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Rep. of Korea use 5-digit postcode #393
Long time a go, Korea used
I want to make PR for changing from
If I was maintainer of this project, I will provide
>>> fake.postcode() 12345 >>> fake.postcode(length=5) 12345 >>> fake.postcode(length=6) 123-456
How do you think about this?
@fcurella I had research and check with goverment department.
Reference: Official Confirmation Prividing that Old and New Addresses are Identical (warn: cert error) (thanks to @minieetea to help)
Korea has two address and postal code system.
I want refactoring not only post code methods but also address-related methods. They have many confusion.
>>> fake.address() '서울특별시 성두마을 \n 승윤로 831 516-538' >>> fake.address() '경상북도 광원군 \n 화완선거리 6 433-113' >>> fake.address() '대전광역시 세열구 상철온군 4 (422-981)' >>> fake.address() '부산광역시 원주훈군 완의경군 0 (270-305)' >>> fake.address() '전라남도 문리슬시 야통선거리 319 1-7 (136-551)' >>> fake.address() '인천광역시 맹가도군 태성로 7071 96-5 (814-857)' >>> fake.address() '서울특별시 윤정광구 \n 다도동 0100 009동 696호 019-910' >>> fake.address() '울산광역시 유근선구 \n 범균동 5227 1-0 082-219'
I want to seperate and refector address methods.
>>> fake.land_parcel_address() '세종특별자치시 어진동 507'
>>> fake.road_address() '세종특별자치시 도움5로 19 (어진동)' >>> fake.street_name() '도움5로'
>>> fake.address_detail() 'ㅇㅇ아파트 ㅁ동 102호' >>> [fake.metropolitan_city() for x in range(2) ['서울특별시', '부산광역시'] >>> [fake.province() for x in range(3)] ['경기도', '강원도', '경상남도'] >>> [fake.city() for x in range(2)] # API break ['고양시', 'ㅇㅇ시'] >>> [fake.borough() for x in range(2)] ['ㅇㅇ구', 'ㅁㅁ구'] >>> [fake.town() for x in range(3)] ['어진동', 'ㅇㅇ리', 'ㅇㅇ마을'] >>> [fake.building_name() for x in range(2)] ['ㅇㅇ빌라', 'ㅇㅇ아파트']
>>> fake.old_postal_code() '123-456' >>> fake.postcode() '123-456' >>> fake.postal_code() '30114'