Refactor Korean address methods#398
Refactor Korean address methods#398fcurella merged 7 commits intojoke2k:masterfrom item4:korean-address
Conversation
|
For Korean reader If you can provide more location name(such as road name), Please just write comment. I will add it. |
| '{{last_name}}{{last_name}}{{last_name}}{{street_suffix}}', | ||
| '{{first_name}}{{last_name}}{{last_name}}{{street_suffix}}', | ||
| '{{last_name}}{{last_name}}{{street_suffix}}' | ||
| '{{street_names}}', |
There was a problem hiding this comment.
hot about this?
'{{first_name}}{{street_suffixes}}',
There was a problem hiding this comment.
or just remove suffix from street_names.
There was a problem hiding this comment.
{{first_name}}{{street_suffix}} gen 김로 or 이거리. It is so awkward.
There was a problem hiding this comment.
I want to choice second idea.
| '타운', | ||
| '타워', | ||
| ) | ||
| street_suffixes = ('로', '거리') |
There was a problem hiding this comment.
road number and 길 suffix is nice idea. but number is not suffix. I will make street_number method.
1. Unify naming between `road` and `street` 2. Add road number method 3. Add road suffix (길)
| '경상남도', '제주특별자치도') | ||
| """Korea has two address and postal code system. | ||
|
|
||
| ## Address |
There was a problem hiding this comment.
Instead of markdown, can you use ReST Formatting for headers, lists and links? see http://docutils.sourceforge.net/docs/user/rst/quickstart.html for the syntax
There was a problem hiding this comment.
I want to see my docstring as HTML but current document generator do not collect them.
I used `Sphinx domain`_ because this project use sphinx. _ Sphinx domain: http://www.sphinx-doc.org/en/stable/domains.html
|
Looks good, Thank you so much! ✨ |
|
@fcurella Can I know PyPI release schedule? |
|
I doont have mucht time this week, but I think I can release on Tuesday On Wed, Oct 5, 2016 at 1:26 PM, item4 notifications@github.com wrote:
|
|
thanks! |
3 participants
fix #393