Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Korean address methods #398

Merged
merged 7 commits into from Oct 5, 2016
Merged

Refactor Korean address methods #398

merged 7 commits into from Oct 5, 2016

Conversation

item4
Copy link
Contributor

@item4 item4 commented Oct 4, 2016

fix #393

@item4
Copy link
Contributor Author

item4 commented Oct 4, 2016

For Korean reader
한국인 독자분들께

If you can provide more location name(such as road name), Please just write comment. I will add it.
만약 보다 많은 지역명(도로명 등)을 제공해주실 수 있다면 댓글로 남겨주세요. 반영하겠습니다.

'{{last_name}}{{last_name}}{{last_name}}{{street_suffix}}',
'{{first_name}}{{last_name}}{{last_name}}{{street_suffix}}',
'{{last_name}}{{last_name}}{{street_suffix}}'
'{{street_names}}',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hot about this?
'{{first_name}}{{street_suffixes}}',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or just remove suffix from street_names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{first_name}}{{street_suffix}} gen 김로 or 이거리. It is so awkward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to choice second idea.

'타운',
'타워',
)
street_suffixes = ('로', '거리')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

('로', '#로', '거리', '길', '가', '#가')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

road number and suffix is nice idea. but number is not suffix. I will make street_number method.

'경상남도', '제주특별자치도')
"""Korea has two address and postal code system.

## Address
Copy link
Collaborator

@fcurella fcurella Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of markdown, can you use ReST Formatting for headers, lists and links? see http://docutils.sourceforge.net/docs/user/rst/quickstart.html for the syntax

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to see my docstring as HTML but current document generator do not collect them.

I used `Sphinx domain`_ because this project use sphinx.

_ Sphinx domain: http://www.sphinx-doc.org/en/stable/domains.html
@fcurella
Copy link
Collaborator

fcurella commented Oct 5, 2016

Looks good, Thank you so much! ✨

@fcurella fcurella merged commit 75b8e98 into joke2k:master Oct 5, 2016
@item4
Copy link
Contributor Author

item4 commented Oct 5, 2016

@fcurella Can I know PyPI release schedule?

@fcurella
Copy link
Collaborator

fcurella commented Oct 5, 2016

I doont have mucht time this week, but I think I can release on Tuesday

On Wed, Oct 5, 2016 at 1:26 PM, item4 notifications@github.com wrote:

@fcurella https://github.com/fcurella Can I know PyPI release schedule?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#398 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFeB366j75v2QOpfjxKl1IsOheuvLIaks5qw-vJgaJpZM4KNi4K
.

@item4
Copy link
Contributor Author

item4 commented Oct 5, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rep. of Korea use 5-digit postcode
3 participants