New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Korean address methods #398

Merged
merged 7 commits into from Oct 5, 2016

Conversation

Projects
None yet
3 participants
@item4
Contributor

item4 commented Oct 4, 2016

fix #393

@item4

This comment has been minimized.

Contributor

item4 commented Oct 4, 2016

For Korean reader
한국인 독자분들께

If you can provide more location name(such as road name), Please just write comment. I will add it.
만약 보다 많은 지역명(도로명 등)을 제공해주실 수 있다면 댓글로 남겨주세요. 반영하겠습니다.

'{{last_name}}{{last_name}}{{last_name}}{{street_suffix}}',
'{{first_name}}{{last_name}}{{last_name}}{{street_suffix}}',
'{{last_name}}{{last_name}}{{street_suffix}}'
'{{street_names}}',

This comment has been minimized.

@marocchino

marocchino Oct 4, 2016

hot about this?
'{{first_name}}{{street_suffixes}}',

This comment has been minimized.

@marocchino

marocchino Oct 4, 2016

or just remove suffix from street_names.

This comment has been minimized.

@item4

item4 Oct 5, 2016

Contributor

{{first_name}}{{street_suffix}} gen 김로 or 이거리. It is so awkward.

This comment has been minimized.

@item4

item4 Oct 5, 2016

Contributor

I want to choice second idea.

'타운',
'타워',
)
street_suffixes = ('', '거리')

This comment has been minimized.

@marocchino

marocchino Oct 4, 2016

('로', '#로', '거리', '길', '가', '#가')

This comment has been minimized.

@item4

item4 Oct 5, 2016

Contributor

road number and suffix is nice idea. but number is not suffix. I will make street_number method.

item4 added some commits Oct 5, 2016

Refactor road-related format
1. Unify naming between `road` and `street`
2. Add road number method
3. Add road suffix (길)
'경상남도', '제주특별자치도')
"""Korea has two address and postal code system.
## Address

This comment has been minimized.

@fcurella

fcurella Oct 5, 2016

Collaborator

Instead of markdown, can you use ReST Formatting for headers, lists and links? see http://docutils.sourceforge.net/docs/user/rst/quickstart.html for the syntax

This comment has been minimized.

@item4

item4 Oct 5, 2016

Contributor

I did it.

This comment has been minimized.

@item4

item4 Oct 5, 2016

Contributor

I want to see my docstring as HTML but current document generator do not collect them.

Change docstring from markdown to reST
I used `Sphinx domain`_ because this project use sphinx.

_ Sphinx domain: http://www.sphinx-doc.org/en/stable/domains.html
@fcurella

This comment has been minimized.

Collaborator

fcurella commented Oct 5, 2016

Looks good, Thank you so much!

@fcurella fcurella merged commit 75b8e98 into joke2k:master Oct 5, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 94.396%
Details
@item4

This comment has been minimized.

Contributor

item4 commented Oct 5, 2016

@fcurella Can I know PyPI release schedule?

@fcurella

This comment has been minimized.

Collaborator

fcurella commented Oct 5, 2016

I doont have mucht time this week, but I think I can release on Tuesday

On Wed, Oct 5, 2016 at 1:26 PM, item4 notifications@github.com wrote:

@fcurella https://github.com/fcurella Can I know PyPI release schedule?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#398 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFeB366j75v2QOpfjxKl1IsOheuvLIaks5qw-vJgaJpZM4KNi4K
.

@item4

This comment has been minimized.

Contributor

item4 commented Oct 5, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment