Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a full DOM dump error occuring on Ubuntu PHP 7.3 #51

Merged
merged 1 commit into from Mar 20, 2020
Merged

Fix a full DOM dump error occuring on Ubuntu PHP 7.3 #51

merged 1 commit into from Mar 20, 2020

Conversation

@damienalexandre
Copy link
Member

damienalexandre commented Mar 20, 2020

DOM/XML API Version => 20031129

The error is not visible on Travis but I can reproduce locally.

There was 1 failure:

1) JoliTypo\Tests\Html5Test::testFullPageMarkup
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'“Who Let the Dogs Out?” is a song written and originally recorded by Anslem Douglas (titled “Doggie”).'
+'“Who Let the Dogs Out?” is a song written and originally recorded by Anslem Douglas (titled “Doggie”).\n
+</body>\n
+</html>'

Thanks @lyrixx

DOM/XML API Version => 20031129
@lyrixx
lyrixx approved these changes Mar 20, 2020
@lyrixx lyrixx merged commit 20a7909 into master Mar 20, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@lyrixx lyrixx deleted the error73 branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.