New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 3.* version of bovigo/assert #22

Merged
merged 1 commit into from Feb 22, 2018

Conversation

3 participants
@lyrixx
Member

lyrixx commented Jan 4, 2018

I need new features that lives in 3.* but asynit blocks to 2.*.
I can not bump to 3.* as there is a BC break https://github.com/mikey179/bovigo-assert/releases/tag/v3.0.0

@joelwurtz

This comment has been minimized.

Show comment
Hide comment
@joelwurtz

joelwurtz Jan 4, 2018

Member

LGTM

can you update dependencies to php 7.1 min requirement before releasing (and travis file then) ?

Member

joelwurtz commented Jan 4, 2018

LGTM

can you update dependencies to php 7.1 min requirement before releasing (and travis file then) ?

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Jan 4, 2018

Member

can you update dependencies to php 7.1 min requirement before releasing (and travis file then) ?

Why ? We don't really need it. But I have to so so, let's require assert in 3.2

Member

lyrixx commented Jan 4, 2018

can you update dependencies to php 7.1 min requirement before releasing (and travis file then) ?

Why ? We don't really need it. But I have to so so, let's require assert in 3.2

@joelwurtz

This comment has been minimized.

Show comment
Hide comment
@joelwurtz

joelwurtz Jan 4, 2018

Member

Oh yes right, forget my comment

Member

joelwurtz commented Jan 4, 2018

Oh yes right, forget my comment

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Jan 28, 2018

Member

I don't get why the build is broken :( Any idea ?

Member

lyrixx commented Jan 28, 2018

I don't get why the build is broken :( Any idea ?

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx
Member

lyrixx commented Feb 16, 2018

ping @joelwurtz

@joelwurtz joelwurtz merged commit c30330c into master Feb 22, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@joelwurtz joelwurtz deleted the up branch Feb 22, 2018

@joelwurtz

This comment has been minimized.

Show comment
Hide comment
@joelwurtz

joelwurtz Feb 22, 2018

Member

Thanks, build is broken due to a too lower deps version on amphp/socket

Member

joelwurtz commented Feb 22, 2018

Thanks, build is broken due to a too lower deps version on amphp/socket

@kelunik

This comment has been minimized.

Show comment
Hide comment
@kelunik

kelunik Feb 22, 2018

@joelwurtz Where are the deps too low?

kelunik commented Feb 22, 2018

@joelwurtz Where are the deps too low?

@joelwurtz

This comment has been minimized.

Show comment
Hide comment
@joelwurtz

joelwurtz Feb 22, 2018

Member

On my side, it's a bug that was fixed some months ago in socket (or maybe artax, i don't remember exactly). But maybe i'm wrong didn't look up at the detail, however it fails on --prefer-lowest

Member

joelwurtz commented Feb 22, 2018

On my side, it's a bug that was fixed some months ago in socket (or maybe artax, i don't remember exactly). But maybe i'm wrong didn't look up at the detail, however it fails on --prefer-lowest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment