Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on /services/builder/Dockerfile with apt-key #97

Closed
matthieuwerner opened this issue Jun 23, 2020 · 3 comments
Closed

Warning on /services/builder/Dockerfile with apt-key #97

matthieuwerner opened this issue Jun 23, 2020 · 3 comments

Comments

@matthieuwerner
Copy link
Contributor

It should be great to remove the warning on the builder Dockerfile because of the programmatically usage of apt-key :
Warning: apt-key output should not be parsed (stdout is not a terminal)

It seems that there 2 ways to remove this warning :

  • Using the environnement variable APT_KEY_DONT_WARN_ON_DANGEROUS_USAGE
  • Redirect stdout to /dev/null

Both seems ignoring the real security content of the message 👎

 apt-key is used to manage the list of keys used by apt to authenticate
   packages. Packages which have been authenticated using these keys will
   be considered trusted.
   Note that if usage of apt-key is desired the additional installation of
   the GNU Privacy Guard suite (packaged in gnupg) is required. For this
   reason alone the programmatic usage (especially in package maintainer
   scripts!) is strongly discouraged. Further more the output format of all
   commands is undefined and can and does change whenever the underlying
   commands change.  apt-key will try to detect such usage and generates
   warnings on stderr in these cases.

=> For this reason alone the programmatic usage (especially in package maintainer scripts!) is strongly discouraged.

Solution 1 : using an older version of nodejs who is officially supported by this version of Debian 😢
Solution 2 : accept this warning (it's working with)
Solution 3 : ... feel free to propose any better solution :)

@lyrixx
Copy link
Member

lyrixx commented Jun 23, 2020

We don't use the output of apt-key so this is fine to me
https://github.com/jolicode/docker-starter/blob/master/infrastructure/docker/services/builder/Dockerfile#L7

So I'm for solution 2

@welcoMattic
Copy link
Member

I'm ok with this warning too. We know what we do here, and it will disappear when Debian will provide a recent version of NodeJS, no ?

@pyrech
Copy link
Member

pyrech commented Jun 25, 2020

Same here, let's just ignore it

@lyrixx lyrixx closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants