Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workers #62

Merged
merged 1 commit into from Mar 23, 2020
Merged

Refactor workers #62

merged 1 commit into from Mar 23, 2020

Conversation

@pyrech
Copy link
Member

pyrech commented Mar 18, 2020

As discussed internally, the current implementation of workers had a few drawbacks:

  • workers were not always build, so we had to remove the --remove-orphans from the docker-compose up command
  • worker service names were required to start with worker_

This is all fixed with this PR:

  • Worker containers are now always build so we can make the --remove-orphans argument back again (supercedes #60)
  • A variable environment and a docker entrypoint allow to build worker containers without running them (useful when building the whole app)
  • A label is used to find worker containers, instead of using their name
@pyrech pyrech requested a review from lyrixx Mar 18, 2020
@lyrixx lyrixx changed the title Refactore workers Refactor workers Mar 18, 2020
@pyrech pyrech force-pushed the refactore_workers branch from 60f083b to 6a925b6 Mar 23, 2020
@lyrixx
lyrixx approved these changes Mar 23, 2020
@lyrixx lyrixx merged commit 485c551 into master Mar 23, 2020
2 checks passed
2 checks passed
ci/circleci: check-python-cs Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
@lyrixx lyrixx deleted the refactore_workers branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.