Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpClientTransport for Symfony HttpClient on Elastica #15

Merged
merged 3 commits into from Jan 16, 2020

Conversation

@damienalexandre
Copy link
Member

damienalexandre commented Jan 8, 2020

This PR add a new Transport for Elastica, allowing to route all HTTP requests to Symfony HttpClient.

This is nice because it's 100% compatible and you get all the nice things in the HttpClient, for example, debug screen:

image

todo

  • Add tests 馃槵
@renanbr

This comment has been minimized.

Copy link

renanbr commented Jan 8, 2020

Is there any chance of proposing it in ruflin/elastica directly? or a separated package?

@damienalexandre

This comment has been minimized.

Copy link
Member Author

damienalexandre commented Jan 8, 2020

Yes, I want this transport to eventually land in Elastica, I didn't send it there for two reasons:

  • I'm not sure the team maintaining Elastica accept the burden of "one more transport to support";
  • when it's stable ^^ right now it's not tested enough.
README.md Show resolved Hide resolved
@damienalexandre damienalexandre merged commit 98ac885 into master Jan 16, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@damienalexandre damienalexandre deleted the httpClient branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can鈥檛 perform that action at this time.