Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSymfony 5 compatibility #133
Merged
Conversation
damienalexandre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
damienalexandre commentedNov 14, 2019
•
edited
As the project is running 4.4, upgrading to 5.0 is only about the deps / ecosystem.
PR have been made, this brand is working with forks.
I had a class to rename in a traits.
I managed to make the app works with Symfony 5, at some cost.Update Makefile to use the Symfony binary(not needed)