New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to formula compatible with brew tap; fix OSX for 10.9 #8

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
2 participants
@nilbus
Contributor

nilbus commented Dec 2, 2013

As noted in the updated readme, this will allow users to install this formula using brew tap.

For this to work, this repository must be renamed to homebrew-encfs. The existing URLs will redirect to the new repository name and continue to work.

This also includes the updated formula for OSX 10.9 Mavericks noted in #7. This fixes the missing boost symbol issue and closes #7.

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Dec 2, 2013

Contributor

This has been tested against nilbus/homebrew-encfs and works on Mavericks.

Contributor

nilbus commented Dec 2, 2013

This has been tested against nilbus/homebrew-encfs and works on Mavericks.

@willsALMANJ

This comment has been minimized.

Show comment
Hide comment
@willsALMANJ

willsALMANJ Dec 2, 2013

It looks like this pull request is the same as Homebrew/legacy-homebrew#24017 open on the main homebrew repository. You might want to look at Homebrew/legacy-homebrew#24196 which was also opened on the main homebrew repository and has a shorter patch. I'm not sure what is holding up the latter pull request from being merged into homebrew. It might be good to comment on it to draw attention to it.

It looks like this pull request is the same as Homebrew/legacy-homebrew#24017 open on the main homebrew repository. You might want to look at Homebrew/legacy-homebrew#24196 which was also opened on the main homebrew repository and has a shorter patch. I'm not sure what is holding up the latter pull request from being merged into homebrew. It might be good to comment on it to draw attention to it.

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Dec 2, 2013

Contributor

I was under the impression that you repository exists because of the lack
of action they were ready to take in homebrew land. I just left a note
there as well. Thanks!

Contributor

nilbus commented Dec 2, 2013

I was under the impression that you repository exists because of the lack
of action they were ready to take in homebrew land. I just left a note
there as well. Thanks!

@willsALMANJ

This comment has been minimized.

Show comment
Hide comment
@willsALMANJ

willsALMANJ Dec 3, 2013

Cool. I'm not the owner of this repository, just another user who needs to use encfs with osxfuse (I have to have osxfuse installed for other software and having osxfuse and fuse4x installed simultaneously causes problems).

This repository was created to allow installation of encfs with osxfuse, but recently an osxfuse formula was accepted into homebrew (previously, only fuse4x was supported but fuse4x development has ended and it is being merged into osxfuse), so the only hold up for getting an encfs formula that uses osxfuse into the main homebrew repository is for a working pull request to pass testing and review by the homebrew developers.

Cool. I'm not the owner of this repository, just another user who needs to use encfs with osxfuse (I have to have osxfuse installed for other software and having osxfuse and fuse4x installed simultaneously causes problems).

This repository was created to allow installation of encfs with osxfuse, but recently an osxfuse formula was accepted into homebrew (previously, only fuse4x was supported but fuse4x development has ended and it is being merged into osxfuse), so the only hold up for getting an encfs formula that uses osxfuse into the main homebrew repository is for a working pull request to pass testing and review by the homebrew developers.

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Dec 5, 2013

Contributor

Closing in favor of #9

Contributor

nilbus commented Dec 5, 2013

Closing in favor of #9

@nilbus nilbus closed this Dec 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment