Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont render empty document fields #1411

Merged
merged 4 commits into from Aug 21, 2019

Conversation

@saifahn
Copy link
Contributor

commented Aug 15, 2019

No description provided.

saifahn added 3 commits Aug 15, 2019
Update document styling
Remove the ugly default grey square on documentCards. Somewhere along
the line the styling for documentDetails was also made incorrect so
the background was the same colour as the claimCards, meaning no
contrast. This has been fixed but should be improved.
Unify credentialDialog with documentDetails
They are essentially the same so having the same styling and structure
makes sense. This also has the benefit of hiding empty fields now.
@VolkerSchiewe
Copy link
Member

left a comment

This changes only the how documents with empty fields are rendered, doesn't it? Because the test drivers licence is currently displayed under credentials

@saifahn

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

This changes only the how documents with empty fields are rendered, doesn't it? Because the test drivers licence is currently displayed under credentials

Yes, it shouldn't change where documents are rendered. I'm guessing that the test drivers license has the wrong document type? It isn't one of the DOC_TYPES in src/utils/filterDocuments.ts

@Exulansis Exulansis self-requested a review Aug 21, 2019

@Exulansis Exulansis added the review label Aug 21, 2019

@Exulansis

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Tested, works as intended.

@Exulansis Exulansis merged commit bc4f1c5 into develop Aug 21, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Exulansis Exulansis deleted the dont-render-empty-document-fields branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.