jonahwilliams

Follow

Jonah Williams jonahwilliams

Follow

Rock, Flag, and Eagle

1.7k followers · 39 following

@google
Mountain View, CA

Achievements

BetaSend feedback

Achievements

BetaSend feedback

Organizations

Block or Report

Block or report jonahwilliams

Report abuse

Contact GitHub support about this user’s behavior. Learn more about reporting abuse.

Report abuse

Pinned

flutter_shaders flutter_shaders Public

A collection of utilities for working with the FragmentProgram API

Dart 64 13

2,114 contributions in the last year

Learn how we count contributions

Less

More

Activity overview

Contributed to flutter/engine, flutter/flutter, johnmccutchan/fgs and 22 other repositories

Contribution activity

February 2024

Created 22 commits in 2 repositories

Created a pull request in flutter/engine that received 88 comments

[Impeller] improve performance of polyline and stroke generation by reducing allocation and lambda usage.

Attempts to reduce the allocation overhead of the stroke geometry generator, while also making it easier to debug and profile. Reverts the change t…

+576 −404 lines changed • 88 comments

Opened 32 other pull requests in 2 repositories

flutter/engine 8 open 13 merged 3 closed

[Impeller] Allow incremental glyph atlas update.
This contribution was made on Feb 20
[Impeller] Allow setting the contents of a Texture subregion.
This contribution was made on Feb 19
[Android] ArrayList is faster than LinkedList for reasonable N.
This contribution was made on Feb 19
[Impeller] cache onscreen render targets.
This contribution was made on Feb 18
[Impeller] add missing std::move in setup depth stencil.
This contribution was made on Feb 18
[Impeller] force bootstrap render pass.
This contribution was made on Feb 18
[Impeller] use fewer threads for shader bootstrap workers on low core machines.
This contribution was made on Feb 16
Demonstrate mutator issue.
This contribution was made on Feb 16
[Impeller] fix cmd buffer recycling bug in test.
This contribution was made on Feb 13
[Impeller] remove denylist entry.
This contribution was made on Feb 13
[Impeller] force render pass construction on all backends to ensure image layout is transitioned/render pass state setup.
This contribution was made on Feb 10
[Impeller] remove expensive trace events.
This contribution was made on Feb 10
[Impeller] Conditionally use A8 or R8 format glyph atlas based on capabilities.
This contribution was made on Feb 10
[Impeller] add additional setup method that caches more pipelines, warms internal shader code
This contribution was made on Feb 10
[Impeller] Cache tessellated data on impeller::Path objects.
This contribution was made on Feb 9
[iOS] Ensure FlutterMetalLayer has correct backpressure.
This contribution was made on Feb 9
[Impeller] CommandPoolVK recycles command buffers too.
This contribution was made on Feb 8
[Impeller] move path out of PathBuilder in TakePath.
This contribution was made on Feb 7
[Impeller] remove extra buffer usage in compute.
This contribution was made on Feb 6
Collect glyphs up front
This contribution was made on Feb 4
[Impeller] fix flake in compute unittests.
This contribution was made on Feb 2
[Impeller] cache more pipeline variants at startup.
This contribution was made on Feb 1
Update expected golden number.
This contribution was made on Feb 1
[Impeller] remove drawPicture from Aiks Canvas.
This contribution was made on Feb 1

flutter/flutter 7 merged 1 open

[Impeller] skip selectable text goldens for instability.
This contribution was made on Feb 17
[Impeller] skip perspective transformed text goldens.
This contribution was made on Feb 17
[gold] Always provide host ABI to gold config
This contribution was made on Feb 17
[framework] Skip 5 failing framework tests.
This contribution was made on Feb 16
[devicelab] retain prior events for flutter gallery.
This contribution was made on Feb 16
[devicelab] migrate new gallery benchmarks to local copy.
This contribution was made on Feb 15
[devicelab] introduce new old gallery.
This contribution was made on Feb 14
[devicelab] retain first frame data in certain integration tests.
This contribution was made on Feb 14

Reviewed 73 pull requests in 2 repositories

flutter/engine 25 pull requests

[Android] ArrayList is faster than LinkedList for reasonable N.
This contribution was made on Feb 20
[Impeller] Implement YUV texture import and sampling for video player frames.
This contribution was made on Feb 19
[Impeller] Run stroke benchmarks on unclosed paths
This contribution was made on Feb 19
[Impeller] Fix golden flake due to rand use.
This contribution was made on Feb 17
[Impeller] Assign subpass depth on restore rather than creation.
This contribution was made on Feb 17
Try setting a consistent background color.
This contribution was made on Feb 16
[Impeller] use fewer threads for shader bootstrap workers on low core machines.
This contribution was made on Feb 16
[Impeller] add additional setup method that caches more pipelines, warms internal shader code
This contribution was made on Feb 16
[Impeller] Add an error message when failing to write golden screenshot.
This contribution was made on Feb 15
[Impeller] Updated benchmarks
This contribution was made on Feb 15
Provide a matrix inverse shim for GLES 2.0.
This contribution was made on Feb 15
Implement the render_to_surface flag in GPUSurfaceGLImpeller
This contribution was made on Feb 15
Add a &right_filter=params to the Skia Gold links.
This contribution was made on Feb 15
Disable Android API v28 tests on CI.
This contribution was made on Feb 15
fix: consider array size on canvaskit shader data
This contribution was made on Feb 15
Make all Android scenario_app activities full-screen, even on older Android versions.
This contribution was made on Feb 14
[Impeller] Conditionally use A8 or R8 format glyph atlas based on capabilities.
This contribution was made on Feb 14
In run_tests, use the regular path to the Vulkan library if lib.unstripped does not exist
This contribution was made on Feb 14
Temporarily change canvaskit kitchensink test to unblock the skia roll
This contribution was made on Feb 14
Add a comment explaining the lifecycle of tls_command_pool_map.
This contribution was made on Feb 14
[Impeller] add benchmarks for the stroke geometry entity code
This contribution was made on Feb 13
[Impeller] Migrate all ColorSourceContents to use a shared rendering routine.
This contribution was made on Feb 13
Do not use AChoreographer on 32 bit devices
This contribution was made on Feb 13
Revert "Refactor NDK helpers some more, add methods for SurfaceControl/Transaction, tests"
This contribution was made on Feb 13
Add Impeller runtime options to Android scenario_app
This contribution was made on Feb 13
Some pull request reviews not shown.

flutter/flutter 8 pull requests

Manual roll Flutter Engine from b7103bc8b374 to 7de84271eb65
This contribution was made on Feb 16
Manual roll Flutter Engine from edb2745e9834 to bc4dd534a0fa
This contribution was made on Feb 16
[devicelab] introduce new old gallery.
This contribution was made on Feb 15
[devicelab] retain first frame data in certain integration tests.
This contribution was made on Feb 14
Remove message about pub cache that is not actionable
This contribution was made on Feb 13
Move Windows arm64 tests to bringup true
This contribution was made on Feb 10
Layout animated GIFs only once
This contribution was made on Feb 9
Disable star_border_test goldens.
This contribution was made on Feb 7

Created an issue in flutter/flutter that received 6 comments

[Impeller] "EntityPass (Depth=1) contains one or more clips with an unresolved depth value" on flutter gallery.

E/flutter ( 7379): [ERROR:flutter/impeller/base/validation.cc(49)] Break on 'ImpellerValidationBreak' to inspect point of failure: EntityPass (Dept…

6 comments

Opened 18 other issues in 1 repository

flutter/flutter 15 open 3 closed

[Android] Consider using native AImageReader instead of Java ImageReader
This contribution was made on Feb 19
[Android] LinkedList iteration in ImageProducer is surprisingly slow
This contribution was made on Feb 19
[Android] MaybeWaitOnFence doesn't signal with videos/Impeller.
This contribution was made on Feb 19
[Impeller] Enable flutter tester with Impeller configuraiton on Flutter CI and make blocking
This contribution was made on Feb 16
[iOS] What is the point of the transform mutators?
This contribution was made on Feb 16
[Impeller] Concurrent VkPipeline creation is slow on Mokey Device.
This contribution was made on Feb 15
[devicelab] Remove and stop recording unused sub_result metrics.
This contribution was made on Feb 15
[framework] reduce dependencies and move archived flutter/gallery into framework repo for benchmarking.
This contribution was made on Feb 14
[Impeller] All framework devicelab benchmarks are skipping the first (several) frames.
This contribution was made on Feb 13
[Impeller] Metal golden tester seems to miss certain validation failures.
This contribution was made on Feb 12
[Impeller] Use circle tessellator to generate rounded stroke join/caps.
This contribution was made on Feb 6
[Impeller] Cacheable paths adds overhead when paths are unstable.
This contribution was made on Feb 4
[iOS] try using clipToBounds instead of masks for rectangular clips.
This contribution was made on Feb 2
[iOS] Mutator clips should not be applied to clipped elements that are scrolled "offscreen"
This contribution was made on Feb 2
[iOS] positioning UIView elements via frame adjustments might be triggering relayout
This contribution was made on Feb 2
[iOS] Platform view slicing is inefficient
This contribution was made on Feb 2
[iOS] add example app spends a lot of time on subview layout
This contribution was made on Feb 2
[iOS] Ad example app spends a significant amount of time performing software rasterization.
This contribution was made on Feb 2