Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only reply to LL_VERSION_IND once #49

Open
jonas-schievink opened this issue Apr 23, 2019 · 0 comments

Comments

@jonas-schievink
Copy link
Owner

@jonas-schievink jonas-schievink commented Apr 23, 2019

Either master or slave may send the LL_VERSION_IND LL Control PDU, and both will respond to it. According to the spec, you're supposed to keep track of whether you've already sent this and ignore the PDU in that case. We currently rely on the master to implement this correctly, since we'd otherwise end up in an endless loop.

To fix this, we need to add another bool to the real-time LinkLayer state to track whether we've sent this already. Eventually we should collapse all the bool flags into a single byte storing them as bitflags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.