Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out `scroll` or `zerocopy` for de/encoding of PDUs #53

Open
jonas-schievink opened this issue Apr 28, 2019 · 1 comment

Comments

@jonas-schievink
Copy link
Owner

@jonas-schievink jonas-schievink commented Apr 28, 2019

scroll allows deriving decoding and encoding traits, which is just what I want. We should try porting rubble to use that instead of bytes.rs.

We can also try out the zerocopy crate, which allows C-like reinterpretation of arbitrary bytes in safe Rust. Unfortunately it's near impossible to contribute to zerocopy since it's part of fuchsia, but it looks promising.

@jonas-schievink jonas-schievink changed the title Try out `scroll` for de/encoding of PDUs Try out `scroll` or `zerocopy` for de/encoding of PDUs Jul 26, 2019
@jonas-schievink

This comment has been minimized.

Copy link
Owner Author

@jonas-schievink jonas-schievink commented Nov 3, 2019

It'd be pretty easy to add a method to ByteReader that reads any type implementing zerocopy::FromBytes. Then we can gradually move hand-written deserialization code to make use of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.