Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't give up when missing the initial transmit window #77

Open
jonas-schievink opened this issue Sep 28, 2019 · 0 comments

Comments

@jonas-schievink
Copy link
Owner

@jonas-schievink jonas-schievink commented Sep 28, 2019

Currently the link layer will abort the connection when it does not receive the initial connect event:

// Master did not transmit the first packet during this transmit window.
// TODO: Move the transmit window forward by the `connInterval`.
// (do we also need to hop channels here?)
self.conn_event_count += Wrapping(1);
trace!("missed transmit window");
Err(())

This shouldn't happen. Instead, we should do what the comment suggests (and check it against the spec).

The effect of this bug is that establishing a connection can spuriously fail, so this is a reliability issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.