--follow no longer works for blame or pickaxe #102

Closed
tsibley opened this Issue Nov 9, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@tsibley
Contributor

tsibley commented Nov 9, 2012

40868f7 breaks usages like tig blame --follow tig.c and tig -Sfoo --follow. I took a quick look at the code, but I'm not up to date anymore with tig's option parsing/backend git commands. I don't think --follow is actually a git rev-list flag, but a git diff flag (looking at the man pages and git source).

The trace makes the cause of the symptom obvious, at least:

git rev-parse --no-revs --no-flags --follow tig.c 
git rev-parse --flags --no-revs --follow tig.c 
git rev-parse --symbolic --revs-only --follow tig.c 
git rev-parse --git-dir --is-inside-work-tree --show-cdup --show-prefix 
git config --list 
git symbolic-ref HEAD 
git ls-remote .git 
git cat-file blob --follow:tig.c 
error: unknown option `follow:tig.c'

(Originally reported as a commit comment, but didn't want it to get lost without an issue.)

@jonas

This comment has been minimized.

Show comment Hide comment
@jonas

jonas Nov 9, 2012

Owner

Thanks, Thomas.
On Nov 9, 2012 2:15 AM, "Thomas Sibley" notifications@github.com wrote:

40868f7 40868f7 breaks usages like tig
blame --follow tig.c and tig -Sfoo --follow. I took a quick look at the
code, but I'm not up to date anymore with tig's option parsing/backend git
commands. I don't think --follow is actually a git rev-list flag, but a git
diff flag (looking at the man pages and git source).

The trace makes the cause of the symptom obvious, at least:

git rev-parse --no-revs --no-flags --follow tig.c
git rev-parse --flags --no-revs --follow tig.c
git rev-parse --symbolic --revs-only --follow tig.c
git rev-parse --git-dir --is-inside-work-tree --show-cdup --show-prefix
git config --list
git symbolic-ref HEAD
git ls-remote .git
git cat-file blob --follow:tig.c
error: unknown option `follow:tig.c'

(Originally reported as a commit comment, but didn't want it to get lost
without an issue.)


Reply to this email directly or view it on GitHubhttps://github.com/jonas/tig/issues/102.

Owner

jonas commented Nov 9, 2012

Thanks, Thomas.
On Nov 9, 2012 2:15 AM, "Thomas Sibley" notifications@github.com wrote:

40868f7 40868f7 breaks usages like tig
blame --follow tig.c and tig -Sfoo --follow. I took a quick look at the
code, but I'm not up to date anymore with tig's option parsing/backend git
commands. I don't think --follow is actually a git rev-list flag, but a git
diff flag (looking at the man pages and git source).

The trace makes the cause of the symptom obvious, at least:

git rev-parse --no-revs --no-flags --follow tig.c
git rev-parse --flags --no-revs --follow tig.c
git rev-parse --symbolic --revs-only --follow tig.c
git rev-parse --git-dir --is-inside-work-tree --show-cdup --show-prefix
git config --list
git symbolic-ref HEAD
git ls-remote .git
git cat-file blob --follow:tig.c
error: unknown option `follow:tig.c'

(Originally reported as a commit comment, but didn't want it to get lost
without an issue.)


Reply to this email directly or view it on GitHubhttps://github.com/jonas/tig/issues/102.

jonas added a commit that referenced this issue Mar 30, 2013

[#102] Revert 40868f7 which breaks blame and pickaxe support for follow
The commit breaks `tig blame --follow tig.c` and `tig -Sfoo --follow`.
@jonas

This comment has been minimized.

Show comment Hide comment
@jonas

jonas Mar 30, 2013

Owner

OK, finally reverted.

Owner

jonas commented Mar 30, 2013

OK, finally reverted.

@jonas jonas closed this Mar 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment