New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 2.0 release is broken because of typo REFRESH_MODE_MANUEL in src/watch.c #337

Closed
jaapz opened this Issue Oct 13, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@jaapz

jaapz commented Oct 13, 2014

The 2.0 release located in http://jonas.nitro.dk/tig/releases/ is broken because of a typo in src/watch.c. This obviously breaks compilation.

jaapz at jipjip in ~/downloads/tig-2.0 
$ diff -u oldwatch.c src/watch.c
--- oldwatch.c  2014-10-13 09:55:16.923519703 +0200
+++ src/watch.c 2014-10-13 09:53:38.972955213 +0200
@@ -154,7 +154,7 @@
 static bool
 watch_no_refresh(enum watch_event event)
 {
-   return opt_refresh_mode == REFRESH_MODE_MANUEL ||
+   return opt_refresh_mode == REFRESH_MODE_MANUAL ||
           (opt_refresh_mode == REFRESH_MODE_AFTER_COMMAND &&
        event != WATCH_EVENT_AFTER_EXTERNAL);
 }
@jonas

This comment has been minimized.

Show comment
Hide comment
@jonas

jonas Oct 13, 2014

Owner

Thanks for the patch but this was fixed in tig-2.0.1 (via #283). Is there any specific reason why you want to use tig-2.0 instead of one of the more recent releases?

Owner

jonas commented Oct 13, 2014

Thanks for the patch but this was fixed in tig-2.0.1 (via #283). Is there any specific reason why you want to use tig-2.0 instead of one of the more recent releases?

@jonas jonas added the Fix proposed label Oct 13, 2014

@jonas

This comment has been minimized.

Show comment
Hide comment
@jonas

jonas Nov 9, 2014

Owner

As explained this is already fixed.

Owner

jonas commented Nov 9, 2014

As explained this is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment