Getting encoding problem after upgrading to tig 1.0 #62

Closed
leemars opened this Issue May 28, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@leemars

leemars commented May 28, 2012

I have a git repository in which files and logs are written in GB18030 encoding. It works well when I used tig 0.18. I just need to set i18n.commitEncoding to GB18030, and set LC_CTYPE to zh_CN.GB18030. But after upgrading to tig 1.0, I can't find a way to get it work anymore. I found that in commit 6b195c0, it forces to use UTF-8 to decode anything. But for me there are GB18030 encoded characters in the files, and git log with --encoding parameter will not convert the diff of files. Is there any way to get it work again? Thanks :)

@alexband

This comment has been minimized.

Show comment Hide comment
@alexband

alexband Jun 14, 2012

this affects me.@jonas

this affects me.@jonas

jonas added a commit that referenced this issue Aug 20, 2012

[GH #62] Make the use of encoding arguments optional
Reworks changes in commit 6b195c0 to
not force git to reencode output to UTF-8, when i18n.commitencoding or
gui.encoding is set.
@jonas

This comment has been minimized.

Show comment Hide comment
@jonas

jonas Aug 20, 2012

Owner

Could one of you try the branch optional-encoding-argument.

Owner

jonas commented Aug 20, 2012

Could one of you try the branch optional-encoding-argument.

@leemars

This comment has been minimized.

Show comment Hide comment
@leemars

leemars Aug 20, 2012

Hi jonas, thanks for your response and sorry for my last "it works for me" PR. I tried branch optional-encoding-argument, with LC_CTYPE="en_US.UTF-8" and LC_CTYPE="zh_CN.GB18030". Again, it works for me. :) Hope that it will be released asap.

leemars commented Aug 20, 2012

Hi jonas, thanks for your response and sorry for my last "it works for me" PR. I tried branch optional-encoding-argument, with LC_CTYPE="en_US.UTF-8" and LC_CTYPE="zh_CN.GB18030". Again, it works for me. :) Hope that it will be released asap.

jonas added a commit that referenced this issue Aug 24, 2012

[GH #62] Make the use of encoding arguments optional
Reworks changes in commit 6b195c0 to
not force git to reencode output to UTF-8, when i18n.commitencoding or
gui.encoding is set.
@jonas

This comment has been minimized.

Show comment Hide comment
@jonas

jonas Aug 24, 2012

Owner

Great, thanks for testing.

Owner

jonas commented Aug 24, 2012

Great, thanks for testing.

@jonas jonas closed this Aug 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment