New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be bit faster #3

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
2 participants
@bayashi
Contributor

bayashi commented Jan 17, 2015

I think this diff is useful for speed. But It will bit change a behavior.

Before we get package name 'Bar' from below file(included 2 package names).

package Foo;
1;
package Bar;
1;

After merged this p-r, we get package name 'Foo'.

Anyway, we expect to get 'Foo'.

@jonasbn

This comment has been minimized.

Show comment
Hide comment
@jonasbn

jonasbn Jan 17, 2015

Owner

Hmmm, I do not like the idea of changing the behaviour, but I do like the idea of faster. Module::Info::File provides all packages in a file, so the behaviour is sort of important, where as what you propose, actually does information hiding, which I am not sure is a good idea in this case - what do you think?

Owner

jonasbn commented Jan 17, 2015

Hmmm, I do not like the idea of changing the behaviour, but I do like the idea of faster. Module::Info::File provides all packages in a file, so the behaviour is sort of important, where as what you propose, actually does information hiding, which I am not sure is a good idea in this case - what do you think?

@jonasbn jonasbn self-assigned this Jan 17, 2015

@bayashi

This comment has been minimized.

Show comment
Hide comment
@bayashi

bayashi Jan 18, 2015

Contributor

@jonasbn
Thank you for your reply.
I think changing behaviour is just only below case: without VERSION.

package Foo;
1;

package Bar;
1;

We get 'Bar' as package name.

Below normal case that with VERSION line, then the behaviour is same.

package Foo;
our $VERSION = '0.01';
1;

package Bar;
1;

I think the first case(without VERSION) is very rare.
And in first case, we would want to get 'Foo' as package name instead of 'Bar'.
Usually, my p-r is OK, I guess.

Contributor

bayashi commented Jan 18, 2015

@jonasbn
Thank you for your reply.
I think changing behaviour is just only below case: without VERSION.

package Foo;
1;

package Bar;
1;

We get 'Bar' as package name.

Below normal case that with VERSION line, then the behaviour is same.

package Foo;
our $VERSION = '0.01';
1;

package Bar;
1;

I think the first case(without VERSION) is very rare.
And in first case, we would want to get 'Foo' as package name instead of 'Bar'.
Usually, my p-r is OK, I guess.

@jonasbn jonasbn added the enhancement label Jan 3, 2017

@jonasbn jonasbn merged commit f5eb36c into jonasbn:master Jan 3, 2017

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment