New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Clojure 1.9 namespaced maps #201

Closed
brabster opened this Issue Jul 4, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@brabster
Copy link

brabster commented Jul 4, 2016

Hi there,

Clojure 1.9 is introducing namespaced maps and they cause an error in kibit. I appreciate that this is an upcoming feature, just a heads-up.

When eastwood encounters a namespaced map, we get:

linting failed:
ExceptionInfo Reader tag must be a symbol
    clojure.core/ex-info (core.clj:4718)
    clojure.core/ex-info (core.clj:4718)
    eastwood.copieddeps.dep10.clojure.tools.reader.reader-types/reader-error (reader_types.clj:330)
    eastwood.copieddeps.dep10.clojure.tools.reader.reader-types/reader-error (reader_types.clj:326)
@jafingerhut

This comment has been minimized.

Copy link
Collaborator

jafingerhut commented Jul 4, 2016

Thanks for the reminder. Eastwood definitely needs an update from the tools.reader library to handle this, which Nicola Mometto may have committed to that project already. I haven't tested it out yet, but will. Any recommendations on open source projects that already take advantage of this feature on which Eastwood could be tested?

@brabster

This comment has been minimized.

Copy link
Author

brabster commented Jul 4, 2016

My project uses namespaced maps in its tests, eg. https://github.com/brabster/crucible/blob/master/test/crucible/aws/dynamodb_test.clj

I was using eastwood until I hit the problem. Hope that helps.

@skuro

This comment has been minimized.

Copy link

skuro commented May 24, 2017

tools.reader 1.0.0-RC1 was just released including the support for namespaced maps

@jafingerhut

This comment has been minimized.

Copy link
Collaborator

jafingerhut commented Oct 11, 2017

It isn't in a released Eastwood version yet, but I have recently updated Eastwood source code to use the latest version of tools.reader, which should address this issue.

If you want to try it out to see if it fixes the issue for you before the next Eastwood release, you can check out these instructions for locally installing an unreleased version of Eastwood from source code: https://github.com/jonase/eastwood#for-eastwood-developers

@jafingerhut jafingerhut added this to the Eastwood 0.2.5 milestone Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment