New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested requires which bring in aliases used with keywords cause issues #202

Open
jeaye opened this Issue Sep 26, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@jeaye
Copy link

jeaye commented Sep 26, 2017

I've read through #14 and I see that a PR was merged for it here: #198 From what I see, this isn't in the latest stable release, so I've been working on the latest beta [lein-kibit "0.1.6-beta2"]. Here is the most minimal reproduction case:

┌─(✓)[jeaye@oryx]─[~/projects/tmp][22:11:46]
└──╼ lein new app kibit-test
Generating a project called kibit-test based on the 'app' template.
┌─(✓)[jeaye@oryx]─[~/projects/tmp][22:11:55]
└──╼ cd kibit-test/
┌─(✓)[jeaye@oryx]─[~/projects/tmp/kibit-test][22:11:57]
└──╼ vim src/kibit_test/core.clj 
┌─(✓)[jeaye@oryx]─[~/projects/tmp/kibit-test][22:12:32]
└──╼ cat src/kibit_test/core.clj 
(ns kibit-test.core
  (:gen-class)
  (:require [clojure
             [string :as string]]))

(defn -main
  [& args]
  (println ::string/uh-oh))
┌─(✓)[jeaye@oryx]─[~/projects/tmp/kibit-test][22:12:37]
└──╼ lein run
:clojure.string/uh-oh
┌─(✓)[jeaye@oryx]─[~/projects/tmp/kibit-test][22:12:48]
└──╼ lein kibit
Check failed -- skipping rest of file
[line 8, col 26] Invalid keyword: ::string/uh-oh.

@danielcompton danielcompton added the bug label Sep 26, 2017

@danielcompton

This comment has been minimized.

Copy link
Collaborator

danielcompton commented Sep 26, 2017

Thanks for reporting this, I think the reader probably needs to be extended to understand nested requires.

@arrdem

This comment has been minimized.

Copy link
Collaborator

arrdem commented Sep 26, 2017

Argh we wrote our own require parser at some point didn't we

@danielcompton

This comment has been minimized.

@jeaye

This comment has been minimized.

Copy link
Author

jeaye commented Jan 6, 2018

Happy new year! Any update on the priority of this one?

@arrdem

This comment has been minimized.

Copy link
Collaborator

arrdem commented Jan 7, 2018

Still no priority on this, but it happens that I wrote a ns parser for another project recently so we should be able to get a fix for this out whenever I can find an hour to get that code shuffled around and packaged for use here.

@jeaye

This comment has been minimized.

Copy link
Author

jeaye commented Jan 7, 2018

Good to know. Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment