Don't suggest (.foo) for (. foo) when foo is a list #33

Closed
sjl opened this Issue May 24, 2012 · 3 comments

Comments

Projects
None yet
2 participants
Contributor

sjl commented May 24, 2012

Right now Riemann's codebase gets suggestions like this:

== riemann.logging ==
[21] Consider:
  (.clojure.lang.LazySeq@fe724234 (Logger/getLogger logger))
instead of:
  (. (Logger/getLogger logger) (setLevel level))

[44] Consider:
  (.clojure.lang.LazySeq@7b82a37c (Logger/getRootLogger))
instead of:
  (. (Logger/getRootLogger) (setLevel Level/INFO))

Those obviously won't work.

Owner

jonase commented May 24, 2012

Which version of kibit are you rusning? This should be fixed in kibit 0.0.4 which was released a few days ago.

Contributor

sjl commented May 24, 2012

That's the one I'm using, still happens.

Owner

jonase commented May 24, 2012

ok. Thanks! I'll take a look.

@jonase jonase closed this in 2a899b4 Jun 26, 2012

tsdh pushed a commit to tsdh/kibit that referenced this issue Sep 13, 2012

Merge pull request #43 from duelinmarkers/fix-dot-rule-when-member-is…
…-a-list

Handle list member-access in dot form. Fixes #33.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment