invalid suggestions for into #83

Closed
sgt opened this Issue Aug 1, 2013 · 1 comment

Projects

None yet

2 participants

@sgt
sgt commented Aug 1, 2013

(into [] ...) is not always equivalent to (vec ...), for example when the argument must be used within a reducer (a common case with core.reducers functions). In these cases, "into" works since it uses reduce internally, whereas "vec" doesn't.

Maybe this rule should be deactivated by default.

@danielcompton danielcompton added the bug label Nov 9, 2014
@danielcompton
Collaborator

Adding comments to suggestions is being tracked in #107. This would let you explain the difference between into [] and vec when suggesting the change so people can understand when it's not appropriate to use vec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment