Suggest when-not for if-not with single branch #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, is this still ok to merge? What was the reason for closing? |
|
I personally find this more clear, but I wasn't sure if there was consensus around this convention. Added a commit for the positive check as well and reopened. It's good to merge if you agree with the recommendation. |
|
Similarly to #2, there isn't complete consensus around this. Being able to specify which rules are included will be helpful. I'll have a think about whether to merge this now, or once that is in. Thanks! |
bbakersmith
force-pushed
the
master
branch
2 times, most recently
from
786d007
to
47063c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.