Android SDK 28

Including Lint 3.2.0
jonasoreland · Oct 7, 2018 · 40e4cbe · 40e4cbe
1 parent 09b0521
commit 40e4cbe
Show file tree

Hide file tree

Showing 12 changed files with 52 additions and 35 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -23,7 +23,7 @@ android:
         #- tools #latest, 26.0.2 as of 2017-07-30
         - platform-tools #latest, 26.0.0 as of 2017-07-30
         - build-tools-28.0.2
-        - android-27
+        - android-28
         - extra-android-m2repository
         - extra-google-m2repository
         - extra-google-google_play_services

diff --git a/app/AndroidManifest.xml b/app/AndroidManifest.xml
@@ -39,6 +39,7 @@
     <uses-permission android:name="${applicationId}.permission.MAPS_RECEIVE"/>
     <uses-permission android:name="android.permission.BLUETOOTH"/>
     <uses-permission android:name="android.permission.BLUETOOTH_ADMIN"/>
+    <uses-permission android:name="android.permission.FOREGROUND_SERVICE"/>
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
 
     <application

diff --git a/app/lint-baseline.xml b/app/lint-baseline.xml
@@ -1,20 +1,27 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<issues format="4" by="lint 3.1.3">
+<issues format="4" by="lint 3.2.0" client="gradle" variant="latestRelease" version="3.2.0">
+
+    <issue
+        id="GradleCompatible"
+        message="All com.android.support libraries must use the exact same version specification (mixing versions can lead to runtime crashes). Found versions 28.0.0, 27.1.1. Examples include `com.android.support:animated-vector-drawable:28.0.0` and `com.android.support:support-media-compat:27.1.1`">
+        <location
+            file="build.gradle"/>
+    </issue>
 
     <issue
         id="GradleDependency"
-        message="A newer version of com.android.support:design than 24.1.0 is available: 27.1.1"
+        message="A newer version of com.android.support:design than 24.1.0 is available: 28.0.0"
         errorLine1="    latestImplementation &quot;com.android.support:design:${rootProject.ext.supportLibrary}&quot;"
         errorLine2="    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
         <location
             file="build.gradle"
-            line="120"
+            line="121"
             column="5"/>
     </issue>
 
     <issue
         id="GradleDependency"
-        message="A newer version of com.google.android.gms:play-services-wearable than 11.0.4 is available: 15.0.1"
+        message="A newer version of com.google.android.gms:play-services-wearable than 11.0.4 is available: 16.0.1"
         errorLine1="    latestImplementation &quot;com.google.android.gms:play-services-wearable:${rootProject.ext.googlePlayServicesVersion}&quot;"
         errorLine2="    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
         <location
@@ -30,18 +37,18 @@
         errorLine2="    ^">
         <location
             file="build.gradle"
-            line="127"
+            line="129"
             column="5"/>
     </issue>
 
     <issue
         id="GradleDependency"
         message="A newer version of com.jjoe64:graphview than 4.2.1 is available: 4.2.2"
-        errorLine1="    froyoImplementation &quot;com.jjoe64:graphview:4.2.1&quot;"
-        errorLine2="    ^">
+        errorLine1="    froyoImplementation &apos;com.jjoe64:graphview:4.2.1&apos;"
+        errorLine2="    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
         <location
             file="build.gradle"
-            line="132"
+            line="133"
             column="5"/>
     </issue>
 
@@ -56,6 +63,17 @@
             column="17"/>
     </issue>
 
+    <issue
+        id="UseSparseArrays"
+        message="Use `new android.support.v4.util.LongSparseArray(...)` instead for better performance"
+        errorLine1="    private final Map&lt;Long, Synchronizer> synchronizersById = new HashMap&lt;>();"
+        errorLine2="                                                              ~~~~~~~~~~~~~~~">
+        <location
+            file="src\org\runnerup\export\SyncManager.java"
+            line="91"
+            column="63"/>
+    </issue>
+
     <issue
         id="IconDuplicates"
         message="The following unrelated icon files have identical contents: title_spinner_pressed.9.png, title_spinner_selected.9.png">
@@ -69,22 +87,22 @@
         id="ContentDescription"
         message="Missing `contentDescription` attribute on image"
         errorLine1="        &lt;ImageView"
-        errorLine2="        ^">
+        errorLine2="         ~~~~~~~~~">
         <location
             file="res\layout\history_row.xml"
             line="38"
-            column="9"/>
+            column="10"/>
     </issue>
 
     <issue
         id="ContentDescription"
         message="Missing `contentDescription` attribute on image"
         errorLine1="    &lt;ImageView"
-        errorLine2="    ^">
+        errorLine2="     ~~~~~~~~~">
         <location
             file="res\layout\step_button.xml"
-            line="39"
-            column="5"/>
+            line="40"
+            column="6"/>
     </issue>
 
 </issues>
diff --git a/app/lint.xml b/app/lint.xml
@@ -1,9 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <lint>
-    <issue id="all">
-        <ignore path="../ANT-Android-SDKs/**" />
-    </issue>
-
     <!-- promote to error, must be handled -->
     <issue id="InlinedApi" severity="fatal" />
     <issue id="InconsistentArrays" severity="fatal" />
@@ -60,16 +56,13 @@
     <issue id="ObsoleteSdkInt" severity="ignore">
         <ignore regexp=".*-r14$" />
     </issue>
-    <!-- used by library? -->
-    <issue id="LogNotTimber" severity="ignore"/>
     <!-- SuppressLint has no effect in gradle plugin 3.0.0, bug? -->
     <issue id="ClickableViewAccessibility" severity="ignore">
         <ignore path="**/NumberPicker.java" />
     </issue>
     <!-- Ignored since minimum version less than 17 requires both left/right and start/end -->
     <issue id="RtlHardcoded" severity="ignore"/>
     <!-- used by library? -->
-    <!--issue id="LogNotTimber" severity="ignore"/-->
     <issue id="ObsoleteLintCustomCheck" severity="ignore">
         <ignore regexp="timber.*" />
     </issue>

diff --git a/app/res/layout/detail.xml b/app/res/layout/detail.xml
@@ -130,7 +130,8 @@
                         android:hint="@string/Notes_about_your_workout"
                         android:inputType="textCapSentences|textMultiLine"
                         android:minLines="4"
-                        android:singleLine="false"/>
+                        android:singleLine="false"
+                        tools:ignore="AutoFill" />
 
                     <LinearLayout
                         android:id="@+id/hrzonesBarLayout"

diff --git a/app/res/layout/filepermission.xml b/app/res/layout/filepermission.xml
@@ -51,7 +51,7 @@
             android:layout_weight="1"
             android:hint="URL"
             android:inputType="textUri"
-            tools:ignore="HardcodedText"/>
+            tools:ignore="HardcodedText,AutoFill"/>
 
     </TableRow>
 

diff --git a/app/res/layout/heartratezonerow.xml b/app/res/layout/heartratezonerow.xml
@@ -36,7 +36,7 @@
         android:layout_height="wrap_content"
         android:layout_weight="1"
         android:inputType="number"
-        tools:ignore="labelFor" />
+        tools:ignore="labelFor,AutoFill" />
 
     <TextView
         android:layout_width="wrap_content"
@@ -49,7 +49,7 @@
         android:layout_height="wrap_content"
         android:layout_weight="1"
 		android:inputType="number"
-        tools:ignore="labelFor" />
+        tools:ignore="labelFor,AutoFill" />
 
     <TextView
         android:layout_width="wrap_content"

diff --git a/app/res/layout/manual.xml b/app/res/layout/manual.xml
@@ -17,6 +17,7 @@
 -->
 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:runnerup="http://schemas.android.com/apk/res-auto"
+    xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/tab_manual"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
@@ -103,6 +104,7 @@
         android:ems="10"
         android:gravity="top|start"
         android:inputType="textMultiLine"
-        android:hint="@string/Add_workout_notes" />
+        android:hint="@string/Add_workout_notes"
+        tools:ignore="AutoFill" />
 
 </RelativeLayout>
diff --git a/app/res/layout/userpass.xml b/app/res/layout/userpass.xml
@@ -53,7 +53,8 @@
                 android:layout_height="wrap_content"
                 android:layout_weight="1"
                 android:inputType="textUri"
-                android:hint="@string/Website" />
+                android:hint="@string/Website"
+                tools:ignore="AutoFill" />
 
         </TableRow>
 
@@ -74,7 +75,7 @@
                 android:layout_height="wrap_content"
                 android:layout_weight="1"
                 android:inputType="textEmailAddress"
-                android:autofillHints="AUTOFILL_HINT_USERNAME"
+                android:autofillHints="emailAddress"
                 android:hint="@string/Username"
                 tools:ignore="UnusedAttribute" />
 
@@ -97,7 +98,7 @@
                 android:layout_height="wrap_content"
                 android:layout_weight="1"
                 android:inputType="textPassword"
-                android:autofillHints="AUTOFILL_HINT_PASSWORD"
+                android:autofillHints="password"
                 android:hint="@string/Password"
                 tools:ignore="UnusedAttribute" />
 

diff --git a/app/src/org/runnerup/tracker/Tracker.java b/app/src/org/runnerup/tracker/Tracker.java
@@ -811,7 +811,7 @@ private void wakeLock(boolean get) {
             PowerManager pm = (PowerManager) this
                     .getSystemService(Context.POWER_SERVICE);
             mWakeLock = pm.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK,
-                    "RunnerUp");
+                    "RunnerUp:wakeLock");
             if (mWakeLock != null) {
                 //Set a timeout, this is before activity is started
                 mWakeLock.acquire(300000);

diff --git a/build.gradle b/build.gradle
@@ -10,6 +10,7 @@ buildscript {
 
 repositories {
     google()
+    jcenter()
 }
 
 project.ext {
@@ -18,10 +19,10 @@ project.ext {
     //Some settings may differ for 'froyo' release
     //minSdkVersion differs between modules
     buildToolsVersion = '28.0.2' //Update Travis manually
-    compileSdkVersion = 27 //Update Travis manually
+    compileSdkVersion = 28 //Update Travis manually
     targetSdkVersion = 28
 
-    supportLibrary = '27.1.1'
+    supportLibrary = '28.0.0'
     //Note: Later Play Services will require a rewrite of NodeApi.NodeListener
     googlePlayServicesVersion = '11.0.4'
     googleWearVersion = '2.3.0'

diff --git a/wear/lint-baseline.xml b/wear/lint-baseline.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<issues format="4" by="lint 3.1.3">
+<issues format="4" by="lint 3.2.0" client="gradle" variant="release" version="3.2.0">
 
     <issue
         id="GradleCompatible"
@@ -10,12 +10,12 @@
 
     <issue
         id="GradleDependency"
-        message="A newer version of com.google.android.gms:play-services-wearable than 11.0.4 is available: 15.0.1"
+        message="A newer version of com.google.android.gms:play-services-wearable than 11.0.4 is available: 16.0.1"
         errorLine1="    implementation &quot;com.google.android.gms:play-services-wearable:${rootProject.ext.googlePlayServicesVersion}&quot;"
         errorLine2="    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
         <location
             file="build.gradle"
-            line="58"
+            line="59"
             column="5"/>
     </issue>