Boolean #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

erikitha wants to merge 9 commits into jonasschmedtmann:master from erikitha:boolean

erikitha commented Jul 14, 2022

No description provided.

erikitha added 9 commits

July 5, 2022 18:37


          learning

461e035


          finish part1-fundamental1

164c8a8


          challenge 1 done

35240bb


           ifselse

57e1e54


          deleting resolution

63ace0d


          if else and strinh

0636a1c


          if-else

a799922


          conversion and coercion

d686e4a


          boolean false- true

5c9854e

cyber-milanovicb commented Jul 14, 2022 via email

I have started already the course. Will these changes make something different?

On Thu, Jul 14, 2022, 03:37 Erica Park ***@***.***> wrote: ------------------------------ You can view, comment on, or merge this pull request online at: #265 Commit Summary - 461e035 <461e035> learning - 164c8a8 <164c8a8> finish part1-fundamental1 - 35240bb <35240bb> challenge 1 done - 57e1e54 <57e1e54> ifselse - 63ace0d <63ace0d> deleting resolution - 0636a1c <0636a1c> if else and strinh - a799922 <a799922> if-else - d686e4a <d686e4a> conversion and coercion - 5c9854e <5c9854e> boolean false- true File Changes (28 files <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files> ) - *D* 01-Fundamentals-Part-1/final/index.html <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-31c6380ae1c7fc6754d630cf2548e4613cde5d488b51cd0bdc5db7d025d5e5dd> (31) - *D* 01-Fundamentals-Part-1/final/script.js <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-b1a476406bf0fd5c8660da70f3c9ec7fbf06f28b607a468df3fbf747f15c7b0e> (468) - *M* 01-Fundamentals-Part-1/starter/index.html <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-0ac9af15a2dc144abfdfe792cec735d6a94bb3e0458878edae10e6d0e7f2681a> (57) - *A* 01-Fundamentals-Part-1/starter/script.js <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-cf35b8de99b6cb00cb7ab79637b500372ffa093d760fcb6f049300c3d081ba6b> (283) - *D* 02-Fundamentals-Part-2/final/index.html <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-8105921cc8706c113f98d2e0617e9cd9ddc20da4e87427da3d0419abfbfaf965> (30) - *D* 02-Fundamentals-Part-2/final/script.js <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-baac16da1f1916c1aab6e92df4c190f2f9aa719bf81a5f0fa75653b3f2ed8a36> (589) - *D* 03-Developer-Skills/final/.prettierrc <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-2c62d1094cb2927569c48f768bd1ba53201e86f0688760b68816a606fd1b40e8> (4) - *D* 03-Developer-Skills/final/index.html <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-6614f357000b78ca8853753c29ac3086873a193418cd96f6dea6fefece6555ee> (30) - *D* 03-Developer-Skills/final/script.js <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-c0279ec98e2f9b229a766e12b237b9acb7ea1e41037e79518749ce64cad7bd5d> (161) - *D* 05-Guess-My-Number/final/.prettierrc <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-f704652e28f3a43e25b57b02b741f4c019a687691543965c4529d6655530b51e> (4) - *D* 05-Guess-My-Number/final/index.html <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-8208bcc6e159004e11eb83488adb336069c90e0a59b2030b4a16ea5ed57cb13c> (32) - *D* 05-Guess-My-Number/final/script.js <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-6601382994b4134a3a5185226c62bd66702e07370e833a52e4507ebc24399feb> (110) - *D* 05-Guess-My-Number/final/style.css <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-168154ce1637e695ef2d7164f9a67f410b582b329e03a8c94aa6eaf31d31ef04> (119) - *D* 06-Modal/final/.prettierrc <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-c09061ccee5de25cc1609170df11bfd6e6cf82d03656c3c6eecb57ed2f5a1d66> (4) - *D* 06-Modal/final/index.html <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-58814f027541f816f2317915763b382e8b82ac6fa8c7972b74b134e435a8de5c> (32) - *D* 06-Modal/final/script.js <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-6e04ef2829fd0bec8853ed8dd9032b6c296a2838e0657847080c6b1fded3d700> (30) - *D* 06-Modal/final/style.css <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-1de7adfa5a34cf53e963bd69fa0947c6abd764d1d146651a4676d21c77e1ca1f> (85) - *D* 07-Pig-Game/final/.prettierrc <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-5e1a2aec3a3141b96b831bc60093a38cc6f596c68ad720c84af68fc13cd314ed> (4) - *D* 07-Pig-Game/final/dice-1.png <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-953127de1b11987f9b619a52526fdaa6530f2ece93404d558710db658d1dd9bd> (0) - *D* 07-Pig-Game/final/dice-2.png <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-ce69f8232ec1786d651dbad0759b2a97229bfd7de4f3339ce2e40017f333291b> (0) - *D* 07-Pig-Game/final/dice-3.png <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-6557d839bb772051b5db55ea259f72ec5a85229c8dcf5eb7b58371a722e1de68> (0) - *D* 07-Pig-Game/final/dice-4.png <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-e87d76aea7d4d13a876014d98621dc1661fb50ece345143853453598e7c286f8> (0) - *D* 07-Pig-Game/final/dice-5.png <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-2809ecddf813d60eafe43d902b2260c9c3da77faa28bcbaf4bc100702ba583f2> (0) - *D* 07-Pig-Game/final/dice-6.png <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-cdd518bdc7483dd95bc4e6855864c12686f5eecb4c163a14d598177473d36902> (0) - *D* 07-Pig-Game/final/index.html <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-7a03bcb9a4a8d346a5c1e619bf6574f33b37756a76d610785489823e6752ca19> (36) - *D* 07-Pig-Game/final/pig-game-flowchart.png <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-ea6a728ae08ff7e08c3dbf48efcf4e99f58aca3132b3359c20d072dbe76716eb> (0) - *D* 07-Pig-Game/final/script.js <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-df2917af1383dcf9a2f4594413961f52ccba3313a01eadee48cb5d239c148896> (98) - *D* 07-Pig-Game/final/style.css <https://github.com/jonasschmedtmann/complete-javascript-course/pull/265/files#diff-1e836d67604228516d42eeed4da19043aca6fe9952d5bb5bf777dc3ccb55382e> (171) Patch Links: - https://github.com/jonasschmedtmann/complete-javascript-course/pull/265.patch - https://github.com/jonasschmedtmann/complete-javascript-course/pull/265.diff — Reply to this email directly, view it on GitHub <#265>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYVR4GSFE2HAAN4QVOI6IXDVT5VOTANCNFSM53QSYIYQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

ChugilC commented Sep 12, 2022

No, it won't affect your learning. Since Jonas don't accept pull requests on his repo as mentioned in FAQ Q:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet