Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goreleaser Integration #24

Merged
merged 3 commits into from Oct 19, 2019

Conversation

@faabiosr
Copy link
Contributor

faabiosr commented Oct 14, 2019

Integration with Goreleaser to release the app for multiples OS.

@faabiosr faabiosr force-pushed the faabiosr:goreleaser branch from 1862939 to 8ce839a Oct 15, 2019
@jonatasbaldin

This comment has been minimized.

Copy link
Owner

jonatasbaldin commented Oct 15, 2019

Hey @faabiosr, thanks for the PR!

The tests are failing, probably because we are using go mod. Could u take a look?

@faabiosr

This comment has been minimized.

Copy link
Contributor Author

faabiosr commented Oct 15, 2019

OK, I will check!

@jonatasbaldin

This comment has been minimized.

Copy link
Owner

jonatasbaldin commented Oct 17, 2019

Thanks! Just ping me when u do :)

@faabiosr faabiosr force-pushed the faabiosr:goreleaser branch 2 times, most recently from 88e8082 to b05460f Oct 17, 2019
@faabiosr

This comment has been minimized.

Copy link
Contributor Author

faabiosr commented Oct 17, 2019

I removed the old golang versions from .travis.yml, but the error still happens and decided to run the tests in my travis-ci account and works!

Look: https://travis-ci.org/faabiosr/ignore/jobs/599292351

I will check the tests.

@jonatasbaldin

This comment has been minimized.

Copy link
Owner

jonatasbaldin commented Oct 18, 2019

Fixed the tests. Can you rebase it please?

Also, I think I need to setup API keys for goreleaser/code conv in my CI, right? If so, could u point me on how?

faabiosr added 2 commits Oct 12, 2019
For the future version of the app and automatic builds, it is
important to has a version flag.
The Makefile was created to facilitate the local development when
we need to run tests and generate coverage files.
@faabiosr faabiosr force-pushed the faabiosr:goreleaser branch 2 times, most recently from 042ba25 to 03cb1a7 Oct 18, 2019
Gorelaser files was developed to generate multiple binaries for the
application, and the travis file was modified to save the code coverage
and run Goreleaser.
@faabiosr faabiosr force-pushed the faabiosr:goreleaser branch from 03cb1a7 to 9795e95 Oct 18, 2019
@faabiosr

This comment has been minimized.

Copy link
Contributor Author

faabiosr commented Oct 18, 2019

Rebased!

Well, before merge I recommend you to configure this repository into codecov.io to show the code coverage of the project, also add a envvar called GITHUB_TOKEN in Travis-CI with a personal token

After the merge, create a tag following the semantic versioning (ex: v0.0.1) and the goreleaser will build the app saving the result into repository releases page.

@jonatasbaldin

This comment has been minimized.

Copy link
Owner

jonatasbaldin commented Oct 19, 2019

Nice, let's do it!

@jonatasbaldin jonatasbaldin merged commit e510a53 into jonatasbaldin:master Oct 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jonatasbaldin

This comment has been minimized.

Copy link
Owner

jonatasbaldin commented Oct 19, 2019

(it worked!)

thanks very much

@faabiosr faabiosr deleted the faabiosr:goreleaser branch Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.