Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
On my terminal, prints white-on-white text #78
Hi @njsmith! Do you have a suggestion to improve this?
From my point of view this looks like an issue with your terminal theme, if you have a light background then any light coloured text (from any application) is going to be illegible. If I change it to black, for example, then it’ll be illegible for someone with a dark theme background.
One’s terminal theme should be ensuring that doesn’t happen by making colour choices (foreground and background) that don’t hinder readability.
I'm not sure I understand... are you saying that it's a bug to use a light background in terminals, or...?
I just double-checked and the same behavior happens with the default gnome-terminal theme, so presumably this affects more than just me :-).
I believe that some apps handle this by checking the background color, and picking between two sets of output colors depending on whether the background is closer to 0xffffff or 0x000000.
What I said was that if your terminal emulator is set up to render bright white on top of a light background that sounds very much like a configuration issue with your terminal emulator.
If you have a suggestion for how to improve the behaviour of eliot-tree, by detecting the background colour in compatible emulators, or by proposing a different colour for that item. I'm happy to consider them in the form of a PR.