Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On my terminal, prints white-on-white text #78

Open
njsmith opened this issue Apr 26, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@njsmith
Copy link

commented Apr 26, 2019

On my terminal, eliot-tree output looks like:

image

I find that UUID somewhat hard to read :-)

@jonathanj

This comment has been minimized.

Copy link
Owner

commented Apr 26, 2019

Hi @njsmith! Do you have a suggestion to improve this?

From my point of view this looks like an issue with your terminal theme, if you have a light background then any light coloured text (from any application) is going to be illegible. If I change it to black, for example, then it’ll be illegible for someone with a dark theme background.

One’s terminal theme should be ensuring that doesn’t happen by making colour choices (foreground and background) that don’t hinder readability.

@njsmith

This comment has been minimized.

Copy link
Author

commented Apr 26, 2019

I'm not sure I understand... are you saying that it's a bug to use a light background in terminals, or...?

I just double-checked and the same behavior happens with the default gnome-terminal theme, so presumably this affects more than just me :-).

I believe that some apps handle this by checking the background color, and picking between two sets of output colors depending on whether the background is closer to 0xffffff or 0x000000.

@jonathanj

This comment has been minimized.

Copy link
Owner

commented Apr 26, 2019

What I said was that if your terminal emulator is set up to render bright white on top of a light background that sounds very much like a configuration issue with your terminal emulator.

I tried brew, htop and mtr with a light background and neither of them made any accommodations for my poorly configured terminal emulator. My terminal emulator has a slider to adjust "Minimum contrast" to avoid this situation.

If you have a suggestion for how to improve the behaviour of eliot-tree, by detecting the background colour in compatible emulators, or by proposing a different colour for that item. I'm happy to consider them in the form of a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.