New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample for custom control based on TokenListControl #427

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@markfink

markfink commented Dec 4, 2016

I propose a sample for a custom TokenListControl

I had some difficulties to follow this recipe while I was still learning prompt-toolkit:
#281

I think my sample could be helpful to others

Best,
Mark

@jonathanslenders

This comment has been minimized.

Show comment
Hide comment
@jonathanslenders

jonathanslenders Dec 4, 2016

Owner

Hi @markfink,

Thanks a lot for this pull request! I appreciate it.
I still need to review and merge it, but hope to do it soon.

Thanks,
Jonathan

Owner

jonathanslenders commented Dec 4, 2016

Hi @markfink,

Thanks a lot for this pull request! I appreciate it.
I still need to review and merge it, but hope to do it soon.

Thanks,
Jonathan

@markfink

This comment has been minimized.

Show comment
Hide comment
@markfink

markfink Dec 5, 2016

@jonathanslenders I am looking forward to your review. I am still learning prompt-toolkit and I am sure there is a ton of stuff I do not yet understand.
Best,
Mark

markfink commented Dec 5, 2016

@jonathanslenders I am looking forward to your review. I am still learning prompt-toolkit and I am sure there is a ton of stuff I do not yet understand.
Best,
Mark

@jonathanslenders

This comment has been minimized.

Show comment
Hide comment
@jonathanslenders

jonathanslenders Jun 2, 2018

Owner

Hi @markfink,

I just passed again by this pull request.
With prompt_toolkit 2.0, TokenListControl is now renamed to FormattedTextControl. If you want, you can create a new pull request for 2.0. There are already several examples here: https://github.com/jonathanslenders/python-prompt-toolkit/tree/master/examples/full-screen In the meantime, I hope you don't mind I close this for now.
Excuse me for not having come back earlier.

Jonathan

Owner

jonathanslenders commented Jun 2, 2018

Hi @markfink,

I just passed again by this pull request.
With prompt_toolkit 2.0, TokenListControl is now renamed to FormattedTextControl. If you want, you can create a new pull request for 2.0. There are already several examples here: https://github.com/jonathanslenders/python-prompt-toolkit/tree/master/examples/full-screen In the meantime, I hope you don't mind I close this for now.
Excuse me for not having come back earlier.

Jonathan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment