New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups and modernisations #27

Merged
merged 2 commits into from May 15, 2017

Conversation

Projects
None yet
2 participants
@shlomif
Contributor

shlomif commented May 12, 2017

This is part of the CPAN pull-req challenge. There are more details in the commit msgs.

shlomif added some commits May 12, 2017

Cleanups / modernisations to Makefile.PL.
1. strict+warnings.

2. Explicit returns.

3. Trailing semicolons.

4. No ampersand in subroutine calls.

See http://perl-begin.org/tutorials/bad-elements/ .
Cleanups.
No leading "&"s in subroutine calls. See
http://perl-begin.org/tutorials/bad-elements/ .

@jonathanstowe jonathanstowe merged commit 2fce2c4 into jonathanstowe:master May 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shlomif

This comment has been minimized.

Show comment
Hide comment
@shlomif

shlomif May 15, 2017

Contributor
Contributor

shlomif commented May 15, 2017

@jonathanstowe

This comment has been minimized.

Show comment
Hide comment
@jonathanstowe

jonathanstowe May 15, 2017

Owner

All good, thank you - I'm not quite sure when I am going to make the next release but it's likely to be in th next month or so.

Owner

jonathanstowe commented May 15, 2017

All good, thank you - I'm not quite sure when I am going to make the next release but it's likely to be in th next month or so.

@shlomif

This comment has been minimized.

Show comment
Hide comment
@shlomif

shlomif May 15, 2017

Contributor
Contributor

shlomif commented May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment