Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated requirements to require wp-cli-bundle. #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattneal-stafflink
Copy link

When using this package on a Composer based project, this package installs wp-cli/wp-cli, and causes issues if you require other packages. I suggest we replace it with wp-cli/wp-cli-bundle to avoid issues.

When using this package on a Composer based project, this package installs `wp-cli/wp-cli`, and causes issues if you require other packages. I suggest we replace it with `wp-cli/wp-cli-bundle` to avoid issues.
@jonbp
Copy link
Owner

jonbp commented Oct 19, 2023

Thanks for your PR Matt. Apologies for the delay in getting back to you 😅

Just wondering, could you elaborate on the issues you're having? I'm kind of reserved to bring in the whole bundle as I'd like to keep the plugin nice and lean by only bringing in the WP-CLI commands we need to use.

@mattneal-stafflink
Copy link
Author

Hey @jonbp , oof, I probably should have left a more detailed pull request on this one, but basically when I installed it, from memory, the wp-cli ended being limited to only what is listed in your composer.json.

In hind sight, it's probably an issue on my end, because if you're using it without the full package, then it must be me haha.

I'm currently operating on about 4 hours sleep, so my brain is a bit foggy, but I do recall something changing with the wp-cli that requires some projects to change the dependancy used? ...I dunno. So so sorry for the jibberish reply.

If I get time, I can retry it again, I'd honestly completely forgot about this repo, but I still don't have a solution like this in our workflow, so I might take another look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants