Jonathan Chambers joncham

Organizations

Unity Technologies
joncham commented on pull request Unity-Technologies/mono#212
Jonathan Chambers

Looks good to me.

Jonathan Chambers
Jonathan Chambers
Jonathan Chambers
joncham created repository joncham/AliothBenchmarks
Jonathan Chambers
joncham merged pull request Unity-Technologies/mono#205
Jonathan Chambers
[scripting] temporary fix for customer case 661822.
1 commit with 8 additions and 3 deletions
Jonathan Chambers
joncham merged pull request Unity-Technologies/mono#193
Jonathan Chambers
More changes to work around the isinst bug
5 commits with 44 additions and 36 deletions
joncham commented on pull request Unity-Technologies/mono#193
Jonathan Chambers

Okay, I know see this is just for enums which probably don't have too many items to search for. So the boxing is not great, but probably not a real…

joncham commented on pull request Unity-Technologies/mono#193
Jonathan Chambers

Are the following changes just commented out?

joncham commented on pull request Unity-Technologies/mono#191
Jonathan Chambers

This should not be merged as is. I left a note with the issue on the source.

joncham commented on pull request Unity-Technologies/mono#191
Jonathan Chambers

You can't just put this here. This represents a managed object that is allocated from the C# definition. When you use this field later to are writi…

joncham commented on pull request Unity-Technologies/mono#185
Jonathan Chambers

Maybe it would be cleaner to pair the checks with each other, i.e. if (info.values is int [] && !(info.values is uint [])) but in any case this loo…

joncham commented on pull request Unity-Technologies/mono#186
Jonathan Chambers

Looks okay to me.